Commit 7563b7e3 authored by dbeam's avatar dbeam Committed by Commit bot

closure: consider <include>d files when tracking compilation progress.

R=vitalyp@chromium.org,tbreisacher@chromium.org
BUG=407385
NOTRY=true

Review URL: https://codereview.chromium.org/547853002

Cr-Commit-Position: refs/heads/master@{#293836}
parent e2048063
...@@ -12,6 +12,11 @@ _SRC_ROOT = os.path.join(_HERE, '..', '..', '..') ...@@ -12,6 +12,11 @@ _SRC_ROOT = os.path.join(_HERE, '..', '..', '..')
_FROM_SRC = lambda p: os.path.abspath(os.path.join(_SRC_ROOT, p)) _FROM_SRC = lambda p: os.path.abspath(os.path.join(_SRC_ROOT, p))
from sys import path as sys_path
sys_path.insert(0, os.path.join(_HERE, '..'))
import processor
# High priority code to compile. # High priority code to compile.
_NEED_TO_COMPILE = map(_FROM_SRC, [ _NEED_TO_COMPILE = map(_FROM_SRC, [
'chrome/browser/resources', 'chrome/browser/resources',
...@@ -43,11 +48,16 @@ _RELEVANT_JS = lambda f: f.endswith('.js') and not f.startswith(_IGNORE_DIRS) ...@@ -43,11 +48,16 @@ _RELEVANT_JS = lambda f: f.endswith('.js') and not f.startswith(_IGNORE_DIRS)
def main(): def main():
line_cache = {} line_cache = {}
def js_files_in_dir(js_dir): def js_files_and_deps_in_dir(js_dir):
found_files = set() found_files = set()
for root, dirs, files in os.walk(js_dir): for root, dirs, files in os.walk(js_dir):
abs_files = [os.path.abspath(os.path.join(root, f)) for f in files] abs_files = [os.path.abspath(os.path.join(root, f)) for f in files]
found_files.update(filter(_RELEVANT_JS, abs_files)) relevant_files = filter(_RELEVANT_JS, abs_files)
found_files.update(relevant_files)
for f in relevant_files:
found_files.update(processor.Processor(f).included_files)
return found_files return found_files
def num_lines(f): def num_lines(f):
...@@ -72,6 +82,7 @@ def main(): ...@@ -72,6 +82,7 @@ def main():
gyp_dir = os.path.dirname(gyp_file) gyp_dir = os.path.dirname(gyp_file)
target_file = os.path.join(gyp_dir, target['target_name'] + '.js') target_file = os.path.join(gyp_dir, target['target_name'] + '.js')
compiled.add(os.path.abspath(target_file)) compiled.add(os.path.abspath(target_file))
compiled.update(processor.Processor(target_file).included_files)
if 'variables' in target and 'depends' in target['variables']: if 'variables' in target and 'depends' in target['variables']:
depends = target['variables']['depends'] depends = target['variables']['depends']
...@@ -86,7 +97,7 @@ def main(): ...@@ -86,7 +97,7 @@ def main():
files = set() files = set()
for n in _NEED_TO_COMPILE: for n in _NEED_TO_COMPILE:
files.update(js_files_in_dir(n)) files.update(js_files_and_deps_in_dir(n))
need_lines = sum(map(num_lines, files)) need_lines = sum(map(num_lines, files))
print 'need: %d files, %d lines' % (len(files), need_lines) print 'need: %d files, %d lines' % (len(files), need_lines)
...@@ -95,7 +106,7 @@ def main(): ...@@ -95,7 +106,7 @@ def main():
print '%.2f%% done with the code we need to compile' % need_done print '%.2f%% done with the code we need to compile' % need_done
for w in _WANT_TO_COMPILE: for w in _WANT_TO_COMPILE:
files.update(js_files_in_dir(w)) files.update(js_files_and_deps_in_dir(w))
want_lines = sum(map(num_lines, files)) want_lines = sum(map(num_lines, files))
print 'want: %d files, %d lines' % (len(files), want_lines) print 'want: %d files, %d lines' % (len(files), want_lines)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment