IndexedDB: Added IDBIndex.getAll() implementation.

This is the experimental IDBIndex.getAll implementation for
retrieving multiple values in a single request as proposed in
https://www.w3.org/2008/webapps/wiki/IndexedDatabaseFeatures

Mozilla's documentation for IDBIndex.getAll is at:
https://developer.mozilla.org/en-US/docs/Web/API/IDBIndex/getAll

In order to use run Chrome with: --enable-experimental-web-platform-features

BUG=457450

Review URL: https://codereview.chromium.org/1147433002

Cr-Commit-Position: refs/heads/master@{#330631}

content/browser/indexed_db/indexed_db_database.cc

@@ -535,6 +535,7 @@ void IndexedDBDatabase::Abort(int64 transaction_id,
 
 void IndexedDBDatabase::GetAll(int64 transaction_id,
                                int64 object_store_id,
+                               int64 index_id,
                                scoped_ptr<IndexedDBKeyRange> key_range,
                                int64 max_count,
                                scoped_refptr<IndexedDBCallbacks> callbacks) {
@@ -548,7 +549,7 @@ void IndexedDBDatabase::GetAll(int64 transaction_id,
 
   transaction->ScheduleTask(
       base::Bind(&IndexedDBDatabase::GetAllOperation, this, object_store_id,
-                 Passed(&key_range), max_count, callbacks));
+                 index_id, Passed(&key_range), max_count, callbacks));
 }
 
 void IndexedDBDatabase::Get(int64 transaction_id,
@@ -739,6 +740,7 @@ void IndexedDBDatabase::GetOperation(
 
 void IndexedDBDatabase::GetAllOperation(
     int64 object_store_id,
+    int64 index_id,
     scoped_ptr<IndexedDBKeyRange> key_range,
     int64 max_count,
     scoped_refptr<IndexedDBCallbacks> callbacks,
@@ -754,10 +756,19 @@ void IndexedDBDatabase::GetAllOperation(
 
   leveldb::Status s;
 
-  scoped_ptr<IndexedDBBackingStore::Cursor> cursor =
-      backing_store_->OpenObjectStoreCursor(
-          transaction->BackingStoreTransaction(), id(), object_store_id,
-          *key_range, blink::WebIDBCursorDirectionNext, &s);
+  scoped_ptr<IndexedDBBackingStore::Cursor> cursor;
+
+  if (index_id == IndexedDBIndexMetadata::kInvalidId) {
+    // ObjectStore
+    cursor = backing_store_->OpenObjectStoreCursor(
+        transaction->BackingStoreTransaction(), id(), object_store_id,
+        *key_range, blink::WebIDBCursorDirectionNext, &s);
+  } else {
+    // Index
+    cursor = backing_store_->OpenIndexCursor(
+        transaction->BackingStoreTransaction(), id(), object_store_id, index_id,
+        *key_range, blink::WebIDBCursorDirectionNext, &s);
+  }
 
   if (!s.ok()) {
     DLOG(ERROR) << "Unable to open cursor operation: " << s.ToString();

content/browser/indexed_db/indexed_db_database.h

@@ -124,6 +124,7 @@ class CONTENT_EXPORT IndexedDBDatabase
            scoped_refptr<IndexedDBCallbacks> callbacks);
   void GetAll(int64 transaction_id,
               int64 object_store_id,
+              int64 index_id,
               scoped_ptr<IndexedDBKeyRange> key_range,
               int64 max_count,
               scoped_refptr<IndexedDBCallbacks> callbacks);
@@ -206,6 +207,7 @@ class CONTENT_EXPORT IndexedDBDatabase
                     scoped_refptr<IndexedDBCallbacks> callbacks,
                     IndexedDBTransaction* transaction);
   void GetAllOperation(int64 object_store_id,
+                       int64 index_id,
                        scoped_ptr<IndexedDBKeyRange> key_range,
                        int64 max_count,
                        scoped_refptr<IndexedDBCallbacks> callbacks,

content/browser/indexed_db/indexed_db_dispatcher_host.cc

@@ -660,7 +660,7 @@ void IndexedDBDispatcherHost::DatabaseDispatcherHost::OnGetAll(
       parent_, params.ipc_thread_id, params.ipc_callbacks_id));
   connection->database()->GetAll(
       parent_->HostTransactionId(params.transaction_id), params.object_store_id,
-      make_scoped_ptr(new IndexedDBKeyRange(params.key_range)),
+      params.index_id, make_scoped_ptr(new IndexedDBKeyRange(params.key_range)),
       params.max_count, callbacks);
 }
 

content/child/indexed_db/indexed_db_dispatcher.cc

@@ -329,6 +329,7 @@ void IndexedDBDispatcher::RequestIDBDatabaseGetAll(
     int32 ipc_database_id,
     int64 transaction_id,
     int64 object_store_id,
+    int64 index_id,
     const IndexedDBKeyRange& key_range,
     int64 max_count,
     WebIDBCallbacks* callbacks) {
@@ -338,6 +339,7 @@ void IndexedDBDispatcher::RequestIDBDatabaseGetAll(
   params.ipc_database_id = ipc_database_id;
   params.transaction_id = transaction_id;
   params.object_store_id = object_store_id;
+  params.index_id = index_id;
   params.key_range = key_range;
   params.max_count = max_count;
   Send(new IndexedDBHostMsg_DatabaseGetAll(params));

content/child/indexed_db/indexed_db_dispatcher.h

@@ -132,6 +132,7 @@ class CONTENT_EXPORT IndexedDBDispatcher : public WorkerTaskRunner::Observer {
   void RequestIDBDatabaseGetAll(int32 ipc_database_id,
                                 int64 transaction_id,
                                 int64 object_store_id,
+                                int64 index_id,
                                 const IndexedDBKeyRange& key_range,
                                 int64 max_count,
                                 blink::WebIDBCallbacks* callbacks);

content/child/indexed_db/webidbdatabase_impl.cc

@@ -122,15 +122,13 @@ void WebIDBDatabaseImpl::getAll(long long transaction_id,
                                 long long max_count,
                                 bool key_only,
                                 WebIDBCallbacks* callbacks) {
-  // TODO(cmumford): Remove DCHECK's for index_id/key_only once IDBIndex.getAll
-  //                 is implemented.
-  static const int64 kInvalidId = -1;
-  DCHECK_EQ(kInvalidId, index_id);
+  // TODO(cmumford): Remove DCHECK for key_only once IDBIndex.getAllKeys is
+  //                 implemented.
   DCHECK(!key_only);
   IndexedDBDispatcher* dispatcher =
       IndexedDBDispatcher::ThreadSpecificInstance(thread_safe_sender_.get());
   dispatcher->RequestIDBDatabaseGetAll(
-      ipc_database_id_, transaction_id, object_store_id,
+      ipc_database_id_, transaction_id, object_store_id, index_id,
       IndexedDBKeyRangeBuilder::Build(key_range), max_count, callbacks);
 }
 

content/common/indexed_db/indexed_db_messages.h

@@ -136,6 +136,8 @@ IPC_STRUCT_BEGIN(IndexedDBHostMsg_DatabaseGetAll_Params)
   IPC_STRUCT_MEMBER(int64, transaction_id)
   // The object store's id.
   IPC_STRUCT_MEMBER(int64, object_store_id)
+  // The index id.
+  IPC_STRUCT_MEMBER(int64, index_id)
   // The serialized key range.
   IPC_STRUCT_MEMBER(content::IndexedDBKeyRange, key_range)
   // The max number of values to retrieve.