Apply modernize-use-override for blink/renderer/platform

I applied modernize-use-override in blink/renderer/platform
http://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html

Bug: 428099
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I481f68cd5dfce10e19e938fdee31d4efcadfabef
Reviewed-on: https://chromium-review.googlesource.com/1027230Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553524}

third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge_test.cc

@@ -110,7 +110,7 @@ class MockGLES2InterfaceWithImageSupport : public FakeGLES2Interface {
   MOCK_METHOD2(GenTextures, void(GLsizei, GLuint*));
   MOCK_METHOD2(DeleteTextures, void(GLsizei, const GLuint*));
   // Fake
-  void GenMailboxCHROMIUM(GLbyte* name) {
+  void GenMailboxCHROMIUM(GLbyte* name) override {
     name[0] = 1;  // Make non-zero mailbox names
   }
 };
@@ -458,14 +458,14 @@ class MockLogger : public Canvas2DLayerBridge::Logger {
   MOCK_METHOD1(ReportHibernationEvent,
                void(Canvas2DLayerBridge::HibernationEvent));
   MOCK_METHOD0(DidStartHibernating, void());
-  virtual ~MockLogger() = default;
+  ~MockLogger() override = default;
 };
 
 class MockCanvasResourceHost : public CanvasResourceHost {
  public:
-  void NotifySurfaceInvalid() {}
-  void SetNeedsCompositingUpdate() {}
-  void UpdateMemoryUsage() {}
+  void NotifySurfaceInvalid() override {}
+  void SetNeedsCompositingUpdate() override {}
+  void UpdateMemoryUsage() override {}
   MOCK_CONST_METHOD1(RestoreCanvasMatrixClipStack, void(PaintCanvas*));
 };
 

third_party/blink/renderer/platform/graphics/gpu/drawing_buffer_test_helpers.h

@@ -108,12 +108,12 @@ class GLES2InterfaceForTests : public gpu::gles2::GLES2InterfaceStub,
     state_.renderbuffer_binding = renderbuffer;
   }
 
-  void Enable(GLenum cap) {
+  void Enable(GLenum cap) override {
     if (cap == GL_SCISSOR_TEST)
       state_.scissor_enabled = true;
   }
 
-  void Disable(GLenum cap) {
+  void Disable(GLenum cap) override {
     if (cap == GL_SCISSOR_TEST)
       state_.scissor_enabled = false;
   }
@@ -232,7 +232,7 @@ class GLES2InterfaceForTests : public gpu::gles2::GLES2InterfaceStub,
   }
 
   MOCK_METHOD1(DestroyImageMock, void(GLuint imageId));
-  void DestroyImageCHROMIUM(GLuint image_id) {
+  void DestroyImageCHROMIUM(GLuint image_id) override {
     image_sizes_.erase(image_id);
     // No textures should be bound to this.
     CHECK(image_to_texture_map_.find(image_id) == image_to_texture_map_.end());
@@ -241,7 +241,7 @@ class GLES2InterfaceForTests : public gpu::gles2::GLES2InterfaceStub,
   }
 
   MOCK_METHOD1(BindTexImage2DMock, void(GLint imageId));
-  void BindTexImage2DCHROMIUM(GLenum target, GLint image_id) {
+  void BindTexImage2DCHROMIUM(GLenum target, GLint image_id) override {
     if (target == ImageCHROMIUMTextureTarget()) {
       texture_sizes_.Set(bound_textures_[target],
                          image_sizes_.find(image_id)->value);
@@ -251,7 +251,7 @@ class GLES2InterfaceForTests : public gpu::gles2::GLES2InterfaceStub,
   }
 
   MOCK_METHOD1(ReleaseTexImage2DMock, void(GLint imageId));
-  void ReleaseTexImage2DCHROMIUM(GLenum target, GLint image_id) {
+  void ReleaseTexImage2DCHROMIUM(GLenum target, GLint image_id) override {
     if (target == ImageCHROMIUMTextureTarget()) {
       image_sizes_.Set(current_image_id_, IntSize());
       image_to_texture_map_.erase(image_id);

third_party/blink/renderer/platform/graphics/video_frame_submitter_test.cc

@@ -35,7 +35,7 @@ namespace {
 class MockVideoFrameProvider : public cc::VideoFrameProvider {
  public:
   MockVideoFrameProvider() = default;
-  ~MockVideoFrameProvider() = default;
+  ~MockVideoFrameProvider() override = default;
 
   MOCK_METHOD1(SetVideoFrameProviderClient, void(Client*));
   MOCK_METHOD2(UpdateCurrentFrame, bool(base::TimeTicks, base::TimeTicks));
@@ -52,7 +52,7 @@ class MockCompositorFrameSink : public viz::mojom::blink::CompositorFrameSink {
   MockCompositorFrameSink(
       viz::mojom::blink::CompositorFrameSinkRequest* request)
       : binding_(this, std::move(*request)) {}
-  ~MockCompositorFrameSink() = default;
+  ~MockCompositorFrameSink() override = default;
 
   MOCK_METHOD1(SetNeedsBeginFrame, void(bool));
   MOCK_METHOD0(SetWantsAnimateOnlyBeginFrames, void());
@@ -99,7 +99,7 @@ class MockVideoFrameResourceProvider
             cc::LayerTreeSettings()) {
     blink::VideoFrameResourceProvider::Initialize(context_provider);
   }
-  ~MockVideoFrameResourceProvider() = default;
+  ~MockVideoFrameResourceProvider() override = default;
 
   MOCK_METHOD1(Initialize, void(viz::ContextProvider*));
   MOCK_METHOD3(AppendQuads,

third_party/blink/renderer/platform/lifecycle_notifier.h

@@ -50,7 +50,7 @@ class LifecycleNotifier : public GarbageCollectedMixin {
   // and safe to use while handling the notification.
   virtual void NotifyContextDestroyed();
 
-  virtual void Trace(blink::Visitor* visitor) { visitor->Trace(observers_); }
+  void Trace(blink::Visitor* visitor) override { visitor->Trace(observers_); }
 
   bool IsIteratingOverObservers() const {
     return iteration_state_ != kNotIterating;

third_party/blink/renderer/platform/lifecycle_observer.h

@@ -37,7 +37,7 @@ class LifecycleNotifier;
 template <typename Context, typename Observer>
 class LifecycleObserver : public GarbageCollectedMixin {
  public:
-  virtual void Trace(blink::Visitor* visitor) {
+  void Trace(blink::Visitor* visitor) override {
     visitor->Trace(lifecycle_context_);
   }
 

third_party/blink/renderer/platform/pod_red_black_tree.h

@@ -709,7 +709,7 @@ class PODRedBlackTree {
    public:
     Counter() : count_(0) {}
 
-    virtual void Visit(const T&) { ++count_; }
+    void Visit(const T&) override { ++count_; }
     int Count() const { return count_; }
 
    private:

third_party/blink/renderer/platform/scheduler/base/task_queue_selector_unittest.cc

@@ -31,7 +31,7 @@ namespace task_queue_selector_unittest {
 class MockObserver : public TaskQueueSelector::Observer {
  public:
   MockObserver() = default;
-  virtual ~MockObserver() = default;
+  ~MockObserver() override = default;
 
   MOCK_METHOD1(OnTaskQueueEnabled, void(internal::TaskQueueImpl*));
 

third_party/blink/renderer/platform/scheduler/renderer/render_widget_signals_unittest.cc

@@ -21,7 +21,7 @@ namespace render_widget_signals_unittest {
 class MockObserver : public RenderWidgetSignals::Observer {
  public:
   MockObserver() = default;
-  virtual ~MockObserver() = default;
+  ~MockObserver() override = default;
 
   MOCK_METHOD1(SetAllRenderWidgetsHidden, void(bool hidden));
   MOCK_METHOD1(SetHasVisibleRenderWidgetWithTouchHandler,

third_party/blink/renderer/platform/scroll/scroll_animator_test.cc

@@ -111,9 +111,10 @@ class MockScrollableAreaForAnimatorTest
     return ScrollableArea::GetScrollOffset();
   }
 
-  void SetScrollOffset(const ScrollOffset& offset,
-                       ScrollType type,
-                       ScrollBehavior behavior = kScrollBehaviorInstant) {
+  void SetScrollOffset(
+      const ScrollOffset& offset,
+      ScrollType type,
+      ScrollBehavior behavior = kScrollBehaviorInstant) override {
     if (animator)
       animator->SetCurrentOffset(offset);
     ScrollableArea::SetScrollOffset(offset, type, behavior);
@@ -131,7 +132,7 @@ class MockScrollableAreaForAnimatorTest
     return ScrollbarTheme::DeprecatedStaticGetTheme();
   }
 
-  virtual void Trace(blink::Visitor* visitor) {
+  void Trace(blink::Visitor* visitor) override {
     visitor->Trace(animator);
     ScrollableArea::Trace(visitor);
   }

third_party/blink/renderer/platform/scroll/scrollbar_test_suite.h

@@ -90,7 +90,7 @@ class MockScrollableArea : public GarbageCollectedFinalized<MockScrollableArea>,
   }
   bool ScrollAnimatorEnabled() const override { return false; }
   int PageStep(ScrollbarOrientation) const override { return 0; }
-  void ScrollControlWasSetNeedsPaintInvalidation() {}
+  void ScrollControlWasSetNeedsPaintInvalidation() override {}
   void SetScrollOrigin(const IntPoint& origin) {
     ScrollableArea::SetScrollOrigin(origin);
   }
@@ -114,7 +114,7 @@ class MockScrollableArea : public GarbageCollectedFinalized<MockScrollableArea>,
   using ScrollableArea::VerticalScrollbarNeedsPaintInvalidation;
   using ScrollableArea::ClearNeedsPaintInvalidationForScrollControls;
 
-  virtual void Trace(blink::Visitor* visitor) {
+  void Trace(blink::Visitor* visitor) override {
     visitor->Trace(chrome_client_);
     ScrollableArea::Trace(visitor);
   }

third_party/blink/renderer/platform/supplementable.h

@@ -148,7 +148,7 @@ class Supplement : public GarbageCollectedMixin,
                : nullptr;
   }
 
-  virtual void Trace(blink::Visitor* visitor) {
+  void Trace(blink::Visitor* visitor) override {
     visitor->Trace(supplementable_);
   }
 
@@ -204,7 +204,7 @@ class Supplementable : public GarbageCollectedMixin {
 #endif
   }
 
-  virtual void Trace(blink::Visitor* visitor) { visitor->Trace(supplements_); }
+  void Trace(blink::Visitor* visitor) override { visitor->Trace(supplements_); }
   virtual void TraceWrappers(const ScriptWrappableVisitor* visitor) const {
     for (const auto& supplement : supplements_.Values())
       visitor->TraceWrappers(supplement);