Commit 75b542fe authored by torne's avatar torne Committed by Commit bot

Revert of Add RELEASE_ASSERT() for |bucket| in partitionAllocGenericFlags()...

Revert of Add RELEASE_ASSERT() for |bucket| in partitionAllocGenericFlags() (patchset #3 id:40001 of https://codereview.chromium.org/1419023008/ )

Reason for revert:
Asserts no longer necessary; the bug is due to blink reinitialisation (which is now prevented elsewhere) not an internal problem with PartitionAlloc.

Original issue's description:
> Add RELEASE_ASSERT() for |bucket| in partitionAllocGenericFlags()
>
> To diagnose the cause of crashes on WebView.
>
> BUG=514141
>
> Committed: https://crrev.com/e0a8f09ae45e944615cacd795a05b6243e3573e1
> Cr-Commit-Position: refs/heads/master@{#358295}

# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=514141

Review-Url: https://codereview.chromium.org/2444913002
Cr-Commit-Position: refs/heads/master@{#427095}
parent 03c1d5ac
......@@ -829,15 +829,6 @@ ALWAYS_INLINE void* partitionAllocGenericFlags(PartitionRootGeneric* root,
void* ret = nullptr;
{
SpinLock::Guard guard(root->lock);
// TODO(bashi): Remove following RELEAE_ASSERT()s once we find the cause of
// http://crbug.com/514141
#if OS(ANDROID)
RELEASE_ASSERT(bucket >= &root->buckets[0] ||
bucket == &PartitionRootGeneric::gPagedBucket);
RELEASE_ASSERT(bucket <= &root->buckets[kGenericNumBuckets - 1] ||
bucket == &PartitionRootGeneric::gPagedBucket);
RELEASE_ASSERT(root->initialized);
#endif
ret = partitionBucketAlloc(root, flags, size, bucket);
}
PartitionAllocHooks::allocationHookIfEnabled(ret, requestedSize, typeName);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment