Commit 75c39449 authored by Mandy Chen's avatar Mandy Chen Committed by Commit Bot

DevTools: Run presubmit localization checks on commit

Outdated local branch and the use of --bypass-hooks can result in
localizability errors in master. Run the localization checks on commit
so CQ runs can report errors.

Screenshot: https://imgur.com/8kaBsKO

Bug: 941561
Change-Id: I51ca39f76356df48f16a76a2cb46002ff0f2f107
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764274Reviewed-by: default avatarErik Luo <luoe@chromium.org>
Commit-Queue: Mandy Chen <mandy.chen@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#689730}
parent e8058f15
...@@ -196,7 +196,10 @@ def CheckChangeOnUpload(input_api, output_api): ...@@ -196,7 +196,10 @@ def CheckChangeOnUpload(input_api, output_api):
def CheckChangeOnCommit(input_api, output_api): def CheckChangeOnCommit(input_api, output_api):
return [] results = []
results.extend(_CheckDevtoolsLocalizableResources(input_api, output_api))
results.extend(_CheckDevtoolsLocalization(input_api, output_api))
return results
def _getAffectedFiles(input_api, parent_directories, excluded_actions, accepted_endings): # pylint: disable=invalid-name def _getAffectedFiles(input_api, parent_directories, excluded_actions, accepted_endings): # pylint: disable=invalid-name
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment