Commit 75c75705 authored by Vincent Boisselle's avatar Vincent Boisselle Committed by Commit Bot

Change the Y alignment of the section header IPH to match the UI mock

Bug: 1128161
Change-Id: Ic5e6cc0439f88394b0d237490f66329f648d0180
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411488Reviewed-by: default avatarDan H <harringtond@chromium.org>
Commit-Queue: Vincent Boisselle <vincb@google.com>
Cr-Commit-Position: refs/heads/master@{#807071}
parent 44ab0063
...@@ -140,6 +140,8 @@ public class SectionHeaderView extends LinearLayout implements View.OnClickListe ...@@ -140,6 +140,8 @@ public class SectionHeaderView extends LinearLayout implements View.OnClickListe
return result; return result;
} }
}; };
int yInsetPx =
getResources().getDimensionPixelOffset(R.dimen.text_bubble_menu_anchor_y_inset);
helper.requestShowIPH(new IPHCommandBuilder(mMenuView.getContext().getResources(), helper.requestShowIPH(new IPHCommandBuilder(mMenuView.getContext().getResources(),
FeatureConstants.FEED_HEADER_MENU_FEATURE, R.string.ntp_feed_menu_iph, FeatureConstants.FEED_HEADER_MENU_FEATURE, R.string.ntp_feed_menu_iph,
R.string.accessibility_ntp_feed_menu_iph) R.string.accessibility_ntp_feed_menu_iph)
...@@ -147,7 +149,7 @@ public class SectionHeaderView extends LinearLayout implements View.OnClickListe ...@@ -147,7 +149,7 @@ public class SectionHeaderView extends LinearLayout implements View.OnClickListe
.setCircleHighlight(true) .setCircleHighlight(true)
.setShouldHighlight(true) .setShouldHighlight(true)
.setDismissOnTouch(false) .setDismissOnTouch(false)
.setInsetRect(new Rect(0, 0, 0, 0)) .setInsetRect(new Rect(0, 0, 0, -yInsetPx))
.setAutoDismissTimeout(5 * 1000) .setAutoDismissTimeout(5 * 1000)
.setViewRectProvider(rectProvider) .setViewRectProvider(rectProvider)
.build()); .build());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment