Commit 75ed6863 authored by Jan Krcal's avatar Jan Krcal Committed by Commit Bot

[Wallet] Enable disabled single client integration tests

This CL enables all remaining disabled single client wallet integration
tests. The underlying issue should be fixed by CL 1998520 so it should
be safe to re-enable the tests now.

Bug: 997786
Change-Id: Ia5cda9824e3b4a3ffd7f679690020c8d40182bc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010849
Commit-Queue: Marc Treib <treib@chromium.org>
Auto-Submit: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: default avatarMarc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733576}
parent 70cbd880
...@@ -628,14 +628,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientWalletSyncTest, EmptyUpdatesAreIgnored) { ...@@ -628,14 +628,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientWalletSyncTest, EmptyUpdatesAreIgnored) {
// If the server sends the same cards and addresses again, they should not // If the server sends the same cards and addresses again, they should not
// change on the client. We should also not overwrite existing metadata. // change on the client. We should also not overwrite existing metadata.
// Flaky on ASan/TSan only. http://crbug.com/997912 IN_PROC_BROWSER_TEST_F(SingleClientWalletSyncTest, SameUpdatesAreIgnored) {
#if defined(ADDRESS_SANITIZER) || defined(THREAD_SANITIZER)
#define MAYBE_SameUpdatesAreIgnored DISABLED_SameUpdatesAreIgnored
#else
#define MAYBE_SameUpdatesAreIgnored SameUpdatesAreIgnored
#endif
IN_PROC_BROWSER_TEST_F(SingleClientWalletSyncTest,
MAYBE_SameUpdatesAreIgnored) {
GetFakeServer()->SetWalletData( GetFakeServer()->SetWalletData(
{CreateSyncWalletCard(/*name=*/"card-1", /*last_four=*/"0001", {CreateSyncWalletCard(/*name=*/"card-1", /*last_four=*/"0001",
kDefaultBillingAddressID), kDefaultBillingAddressID),
...@@ -692,14 +685,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientWalletSyncTest, ...@@ -692,14 +685,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientWalletSyncTest,
// If the server sends the same cards and addresses with changed data, they // If the server sends the same cards and addresses with changed data, they
// should change on the client. // should change on the client.
// Flaky on Mac/Linux/ChromeOS only. http://crbug.com/997825 IN_PROC_BROWSER_TEST_F(SingleClientWalletSyncTest, ChangedEntityGetsUpdated) {
#if defined(OS_LINUX) || defined(OS_MACOSX) || defined(OS_CHROMEOS)
#define MAYBE_ChangedEntityGetsUpdated DISABLED_ChangedEntityGetsUpdated
#else
#define MAYBE_ChangedEntityGetsUpdated ChangedEntityGetsUpdated
#endif
IN_PROC_BROWSER_TEST_F(SingleClientWalletSyncTest,
MAYBE_ChangedEntityGetsUpdated) {
GetFakeServer()->SetWalletData( GetFakeServer()->SetWalletData(
{CreateSyncWalletCard(/*name=*/"card-1", /*last_four=*/"0002", {CreateSyncWalletCard(/*name=*/"card-1", /*last_four=*/"0002",
kDefaultBillingAddressID), kDefaultBillingAddressID),
...@@ -802,9 +788,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientWalletSyncTest, ...@@ -802,9 +788,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientWalletSyncTest,
// Wallet data should get cleared from the database when the wallet sync type // Wallet data should get cleared from the database when the wallet sync type
// flag is disabled. // flag is disabled.
// Test is flaky: https://crbug.com/997786 IN_PROC_BROWSER_TEST_F(SingleClientWalletSyncTest, ClearOnDisableWalletSync) {
IN_PROC_BROWSER_TEST_F(SingleClientWalletSyncTest,
DISABLED_ClearOnDisableWalletSync) {
GetFakeServer()->SetWalletData({CreateDefaultSyncWalletAddress(), GetFakeServer()->SetWalletData({CreateDefaultSyncWalletAddress(),
CreateDefaultSyncWalletCard(), CreateDefaultSyncWalletCard(),
CreateDefaultSyncPaymentsCustomerData(), CreateDefaultSyncPaymentsCustomerData(),
...@@ -876,16 +860,8 @@ IN_PROC_BROWSER_TEST_F(SingleClientWalletSyncTest, ...@@ -876,16 +860,8 @@ IN_PROC_BROWSER_TEST_F(SingleClientWalletSyncTest,
// Wallet data present on the client should be cleared in favor of the new data // Wallet data present on the client should be cleared in favor of the new data
// synced down form the server. // synced down form the server.
// Flaky (mostly) on ASan/TSan. http://crbug.com/998130
#if defined(ADDRESS_SANITIZER) || defined(THREAD_SANITIZER)
#define MAYBE_NewWalletCardRemovesExistingCardAndProfile \
DISABLED_NewWalletCardRemovesExistingCardAndProfile
#else
#define MAYBE_NewWalletCardRemovesExistingCardAndProfile \
NewWalletCardRemovesExistingCardAndProfile
#endif
IN_PROC_BROWSER_TEST_F(SingleClientWalletSyncTest, IN_PROC_BROWSER_TEST_F(SingleClientWalletSyncTest,
MAYBE_NewWalletCardRemovesExistingCardAndProfile) { NewWalletCardRemovesExistingCardAndProfile) {
ASSERT_TRUE(SetupSync()); ASSERT_TRUE(SetupSync());
autofill::PersonalDataManager* pdm = GetPersonalDataManager(0); autofill::PersonalDataManager* pdm = GetPersonalDataManager(0);
ASSERT_NE(nullptr, pdm); ASSERT_NE(nullptr, pdm);
...@@ -961,15 +937,8 @@ IN_PROC_BROWSER_TEST_F(SingleClientWalletSyncTest, ...@@ -961,15 +937,8 @@ IN_PROC_BROWSER_TEST_F(SingleClientWalletSyncTest,
// Wallet data present on the client should be cleared in favor of the new data // Wallet data present on the client should be cleared in favor of the new data
// synced down form the server. // synced down form the server.
// Flaky (mostly) on ASan/TSan. http://crbug.com/998130
#if defined(ADDRESS_SANITIZER) || defined(THREAD_SANITIZER)
#define MAYBE_NewWalletDataRemovesExistingData \
DISABLED_NewWalletDataRemovesExistingData
#else
#define MAYBE_NewWalletDataRemovesExistingData NewWalletDataRemovesExistingData
#endif
IN_PROC_BROWSER_TEST_F(SingleClientWalletSyncTest, IN_PROC_BROWSER_TEST_F(SingleClientWalletSyncTest,
MAYBE_NewWalletDataRemovesExistingData) { NewWalletDataRemovesExistingData) {
ASSERT_TRUE(SetupSync()); ASSERT_TRUE(SetupSync());
autofill::PersonalDataManager* pdm = GetPersonalDataManager(0); autofill::PersonalDataManager* pdm = GetPersonalDataManager(0);
ASSERT_NE(nullptr, pdm); ASSERT_NE(nullptr, pdm);
...@@ -1085,16 +1054,8 @@ IN_PROC_BROWSER_TEST_F(SingleClientWalletSyncTest, ...@@ -1085,16 +1054,8 @@ IN_PROC_BROWSER_TEST_F(SingleClientWalletSyncTest,
// Tests that a server billing address id set on a card on the client is // Tests that a server billing address id set on a card on the client is
// overwritten when that same card is synced again. // overwritten when that same card is synced again.
// Flaky (mostly) on ASan/TSan. http://crbug.com/998130
#if defined(ADDRESS_SANITIZER) || defined(THREAD_SANITIZER)
#define MAYBE_SameWalletCard_DiscardsOldServerBillingAddressId \
DISABLED_SameWalletCard_DiscardsOldServerBillingAddressId
#else
#define MAYBE_SameWalletCard_DiscardsOldServerBillingAddressId \
SameWalletCard_DiscardsOldServerBillingAddressId
#endif
IN_PROC_BROWSER_TEST_F(SingleClientWalletSyncTest, IN_PROC_BROWSER_TEST_F(SingleClientWalletSyncTest,
MAYBE_SameWalletCard_DiscardsOldServerBillingAddressId) { SameWalletCard_DiscardsOldServerBillingAddressId) {
ASSERT_TRUE(SetupSync()); ASSERT_TRUE(SetupSync());
autofill::PersonalDataManager* pdm = GetPersonalDataManager(0); autofill::PersonalDataManager* pdm = GetPersonalDataManager(0);
ASSERT_NE(nullptr, pdm); ASSERT_NE(nullptr, pdm);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment