Commit 76086840 authored by yhirano@chromium.org's avatar yhirano@chromium.org

ThreadedTestRunner::Run contained a PP_DCHECK with a side effect. Some tests failed because of it.

This CL fixes the problem.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/19790011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213386 0039d316-1c4b-4281-b951-d872f2087c98
parent 4f47e7cb
......@@ -187,7 +187,9 @@ class TestCase {
private:
void Run() {
PP_DCHECK(PP_OK == loop_.AttachToCurrentThread());
int32_t result = loop_.AttachToCurrentThread();
static_cast<void>(result); // result is not used in the RELEASE build.
PP_DCHECK(PP_OK == result);
result_ = (test_case_->*test_to_run_)();
// Now give the loop a chance to clean up.
loop_.PostQuit(true /* should_destroy */);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment