[Android][Performance] Prevent accessory from over-openening keyboard

This CL prevents the keyboard accessory from triggering a keyboard that
hasn't been requested.

Example: Open youtube or chrome://flags
Before this patch:
  The keyboard accessory controller detects that there are passwords for
  this site. Because the search field is focused by default, it will
  request openening the keyboard.
Why this is wrong:
  The controller wrongfully assumed that a focused input field always
  triggers the keyboard. This is wrong, esp. for pageloads.
After this patch:
  The controller requests to open the keyboard iff the accessory sheet
  is opened.

Why has this become a problem now?
Before https://crrev.com/c/1177361, the controller would just request
the accessory to be closed. This caused nasty artifacts and bugs.
Therefore, it requested to open keyboard to dismiss the sheet gently.
This resulted in opening the keyboard too often.

What is potentially impacted by this:
 - Performance tests with search bars: Confirmed
   --> smoothness.*/youtube_pinch_2018 not failing consistently
 - Health tests: Likely confirmed
   system_health.memory_mobile/browse.tools.maps debug run changed
   memory:chrome:all_processes:reported_by_chrome:effective_size
   by 7.7%
 - Startup with previously opened sites: Confirmed
   Following instructions in issue 876228 don't reproduce error.

Bug: 875859, 876025, 876228
Change-Id: Ic5873c07cb8652bc0da5edcca8324f2680baac11
Reviewed-on: https://chromium-review.googlesource.com/1184847Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585454}

chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingCoordinator.java

@@ -72,10 +72,10 @@ public class ManualFillingCoordinator {
     }
 
     /**
-     * Tries to reopen the keyboard which will implicitly show the keyboard accessory bar again.
+     * Opens the keyboard which implicitly dismisses the sheet. Without open sheet, this is a NoOp.
      */
-    public void openKeyboard() {
-        mMediator.onOpenKeyboard();
+    public void swapSheetWithKeyboard() {
+        mMediator.swapSheetWithKeyboard();
     }
 
     void registerActionProvider(

chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingMediator.java

@@ -262,6 +262,13 @@ class ManualFillingMediator
         mAccessorySheet.hide();
     }
 
+    /**
+     * Opens the keyboard which implicitly dismisses the sheet. Without open sheet, this is a NoOp.
+     */
+    void swapSheetWithKeyboard() {
+        if (mAccessorySheet.isShown()) onOpenKeyboard();
+    }
+
     @Override
     public void onOpenKeyboard() {
         assert mActivity != null : "ManualFillingMediator needs initialization.";

chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessoryBridge.java

@@ -75,8 +75,8 @@ class PasswordAccessoryBridge {
     }
 
     @CalledByNative
-    private void openKeyboard() {
-        mManualFillingCoordinator.openKeyboard();
+    private void swapSheetWithKeyboard() {
+        mManualFillingCoordinator.swapSheetWithKeyboard();
     }
 
     @CalledByNative

chrome/browser/android/password_manager/password_accessory_view_android.cc

@@ -69,8 +69,8 @@ void PasswordAccessoryViewAndroid::CloseAccessorySheet() {
       base::android::AttachCurrentThread(), java_object_);
 }
 
-void PasswordAccessoryViewAndroid::OpenKeyboard() {
-  Java_PasswordAccessoryBridge_openKeyboard(
+void PasswordAccessoryViewAndroid::SwapSheetWithKeyboard() {
+  Java_PasswordAccessoryBridge_swapSheetWithKeyboard(
       base::android::AttachCurrentThread(), java_object_);
 }
 

chrome/browser/android/password_manager/password_accessory_view_android.h

@@ -30,7 +30,7 @@ class PasswordAccessoryViewAndroid : public PasswordAccessoryViewInterface {
   void OnItemsAvailable(const std::vector<AccessoryItem>& items) override;
   void OnAutomaticGenerationStatusChanged(bool available) override;
   void CloseAccessorySheet() override;
-  void OpenKeyboard() override;
+  void SwapSheetWithKeyboard() override;
 
   // Called from Java via JNI:
   void OnFaviconRequested(

chrome/browser/password_manager/password_accessory_controller.cc

@@ -173,7 +173,7 @@ void PasswordAccessoryController::OnFilledIntoFocusedField(
     autofill::FillingStatus status) {
   if (status != autofill::FillingStatus::SUCCESS)
     return;                      // TODO(crbug/853766): Record success rate.
-  view_->OpenKeyboard();  // Bring up the keyboard for the still focused field.
+  view_->SwapSheetWithKeyboard();
 }
 
 void PasswordAccessoryController::RefreshSuggestionsForField(
@@ -184,7 +184,7 @@ void PasswordAccessoryController::RefreshSuggestionsForField(
     current_origin_ = origin;
     view_->OnItemsAvailable(CreateViewItems(origin, origin_suggestions_[origin],
                                             is_password_field));
-    view_->OpenKeyboard();  // Should happen automatically.
+    view_->SwapSheetWithKeyboard();
   } else {
     // For unfillable fields, reset the origin and send the empty state message.
     current_origin_ = url::Origin();

chrome/browser/password_manager/password_accessory_controller_unittest.cc

@@ -65,7 +65,7 @@ class MockPasswordAccessoryView : public PasswordAccessoryViewInterface {
   MOCK_METHOD0(OnViewDestroyed, void());
   MOCK_METHOD1(OnAutomaticGenerationStatusChanged, void(bool));
   MOCK_METHOD0(CloseAccessorySheet, void());
-  MOCK_METHOD0(OpenKeyboard, void());
+  MOCK_METHOD0(SwapSheetWithKeyboard, void());
 
  private:
   DISALLOW_COPY_AND_ASSIGN(MockPasswordAccessoryView);
@@ -259,7 +259,7 @@ class PasswordAccessoryControllerTest : public ChromeRenderViewHostTestHarness {
         mock_dialog_factory_.Get(), favicon_service());
     NavigateAndCommit(GURL(kExampleSite));
     EXPECT_CALL(*view(), CloseAccessorySheet()).Times(AnyNumber());
-    EXPECT_CALL(*view(), OpenKeyboard()).Times(AnyNumber());
+    EXPECT_CALL(*view(), SwapSheetWithKeyboard()).Times(AnyNumber());
   }
 
   PasswordAccessoryController* controller() {
@@ -406,12 +406,12 @@ TEST_F(PasswordAccessoryControllerTest, ProvidesEmptySuggestionsMessage) {
 TEST_F(PasswordAccessoryControllerTest, ClosesViewOnSuccessfullFillingOnly) {
   // If the filling wasn't successful, no call is expected.
   EXPECT_CALL(*view(), CloseAccessorySheet()).Times(0);
-  EXPECT_CALL(*view(), OpenKeyboard()).Times(0);
+  EXPECT_CALL(*view(), SwapSheetWithKeyboard()).Times(0);
   controller()->OnFilledIntoFocusedField(FillingStatus::ERROR_NOT_ALLOWED);
   controller()->OnFilledIntoFocusedField(FillingStatus::ERROR_NO_VALID_FIELD);
 
   // If the filling completed successfully, let the view know.
-  EXPECT_CALL(*view(), OpenKeyboard());
+  EXPECT_CALL(*view(), SwapSheetWithKeyboard());
   controller()->OnFilledIntoFocusedField(FillingStatus::SUCCESS);
 }
 
@@ -421,7 +421,8 @@ TEST_F(PasswordAccessoryControllerTest, ClosesViewWhenRefreshingSuggestions) {
   EXPECT_CALL(*view(), OnItemsAvailable(_)).Times(AnyNumber());
 
   EXPECT_CALL(*view(), CloseAccessorySheet());
-  EXPECT_CALL(*view(), OpenKeyboard()).Times(0);  // Don't touch the keyboard!
+  EXPECT_CALL(*view(), SwapSheetWithKeyboard())
+      .Times(0);  // Don't touch the keyboard!
   controller()->RefreshSuggestionsForField(
       url::Origin::Create(GURL(kExampleSite)),
       /*is_fillable=*/false,

chrome/browser/password_manager/password_accessory_view_interface.h

@@ -74,8 +74,8 @@ class PasswordAccessoryViewInterface {
   // Called to inform the view that the accessory sheet should be closed now.
   virtual void CloseAccessorySheet() = 0;
 
-  // Called to inform the view that the accessory sheet should be closed now.
-  virtual void OpenKeyboard() = 0;
+  // Opens a keyboard which dismisses the sheet. NoOp without open sheet.
+  virtual void SwapSheetWithKeyboard() = 0;
 
  private:
   friend class PasswordAccessoryController;