Commit 761d47b9 authored by Ben Kelly's avatar Ben Kelly Committed by Commit Bot

Fix ServiceWorkerNavigationPreloadTest.GetLargeResponseReadableStream to join chunks correctly.

R=mek@chromium.org

Bug: 897764
Change-Id: I256e6d3a051f56fff9f07a4b09b490086a6474d5
Reviewed-on: https://chromium-review.googlesource.com/c/1296190Reviewed-by: default avatarMarijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601888}
parent c9bfc2ec
...@@ -2369,15 +2369,8 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerNavigationPreloadTest, ...@@ -2369,15 +2369,8 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerNavigationPreloadTest,
EXPECT_EQ(1, GetRequestCount(kPageUrl)); EXPECT_EQ(1, GetRequestCount(kPageUrl));
} }
// Fails on Win. See https://crbug.com/897764
#if defined(OS_WIN)
#define MAYBE_GetLargeResponseReadableStream \
DISABLED_GetLargeResponseReadableStream
#else
#define MAYBE_GetLargeResponseReadableStream GetLargeResponseReadableStream
#endif
IN_PROC_BROWSER_TEST_F(ServiceWorkerNavigationPreloadTest, IN_PROC_BROWSER_TEST_F(ServiceWorkerNavigationPreloadTest,
MAYBE_GetLargeResponseReadableStream) { GetLargeResponseReadableStream) {
const char kPageUrl[] = "/service_worker/navigation_preload.html"; const char kPageUrl[] = "/service_worker/navigation_preload.html";
const char kWorkerUrl[] = "/service_worker/navigation_preload.js"; const char kWorkerUrl[] = "/service_worker/navigation_preload.js";
std::string title = "<title>PASS</title>"; std::string title = "<title>PASS</title>";
...@@ -2397,7 +2390,7 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerNavigationPreloadTest, ...@@ -2397,7 +2390,7 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerNavigationPreloadTest,
" var decoder = new TextDecoder();\n" " var decoder = new TextDecoder();\n"
" function nextChunk(chunk) {\n" " function nextChunk(chunk) {\n"
" if (chunk.done)\n" " if (chunk.done)\n"
" return data.join();\n" " return data.join('');\n"
" data.push(decoder.decode(chunk.value));\n" " data.push(decoder.decode(chunk.value));\n"
" return reader.read().then(nextChunk);\n" " return reader.read().then(nextChunk);\n"
" }\n" " }\n"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment