Commit 763eb0db authored by Tim van der Lippe's avatar Tim van der Lippe Committed by Commit Bot

Fix tests for upcoming DevTools change

Test changes required for
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2016757

Bug: 1006759
Change-Id: I54e7e0241033b22749da2261029868c4c86b007e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016635
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: default avatarPaul Lewis <aerotwist@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734486}
parent 0f822905
...@@ -5379,7 +5379,6 @@ crbug.com/911515 [ Mac ] transforms/shadows.html [ Pass Failure ] ...@@ -5379,7 +5379,6 @@ crbug.com/911515 [ Mac ] transforms/shadows.html [ Pass Failure ]
crbug.com/911782 [ Mac ] paint/invalidation/forms/submit-focus-by-mouse-then-keydown.html [ Pass Failure ] crbug.com/911782 [ Mac ] paint/invalidation/forms/submit-focus-by-mouse-then-keydown.html [ Pass Failure ]
# Sheriff 2018-12-06 # Sheriff 2018-12-06
crbug.com/912793 http/tests/devtools/sources/debugger-breakpoints/restore-locations-for-breakpoint-with-broken-source-map.js [ Pass Failure ]
crbug.com/912793 crbug.com/899087 virtual/android/fullscreen/full-screen-iframe-allowed-video.html [ Crash Pass Failure Timeout ] crbug.com/912793 crbug.com/899087 virtual/android/fullscreen/full-screen-iframe-allowed-video.html [ Crash Pass Failure Timeout ]
# Sheriff 2018-12-07 # Sheriff 2018-12-07
...@@ -6384,3 +6383,8 @@ crbug.com/1043675 [ Linux ] virtual/threaded-no-composited-antialiasing/animatio ...@@ -6384,3 +6383,8 @@ crbug.com/1043675 [ Linux ] virtual/threaded-no-composited-antialiasing/animatio
# The transformed region bleeds into the foreground with SkiaRenderer enabled. # The transformed region bleeds into the foreground with SkiaRenderer enabled.
crbug.com/1044032 [ Linux ] css3/filters/backdrop-filter-transform.html [ Failure ] crbug.com/1044032 [ Linux ] css3/filters/backdrop-filter-transform.html [ Failure ]
crbug.com/1044032 [ Linux ] virtual/scalefactor200/css3/filters/backdrop-filter-transform.html [ Failure ] crbug.com/1044032 [ Linux ] virtual/scalefactor200/css3/filters/backdrop-filter-transform.html [ Failure ]
# Required to land DevTools change
crbug.com/106759 http/tests/devtools/command-line-api-inspect.js [ Pass Failure ]
crbug.com/106759 http/tests/devtools/sources/debugger-breakpoints/restore-locations-for-breakpoint-with-broken-source-map.js [ Pass Failure ]
crbug.com/106759 http/tests/devtools/sources/debugger-console/debugger-command-line-api.js [ Pass Failure ]
...@@ -28,15 +28,15 @@ ...@@ -28,15 +28,15 @@
} }
TestRunner.runTestSuite([function testRevealElement(next) { TestRunner.runTestSuite([function testRevealElement(next) {
TestRunner.addSniffer(Common.Revealer, 'reveal', step2, true); const originalReveal = Common.Revealer.reveal;
Common.Revealer.setRevealForTest((node) => {
if (!(node instanceof SDK.RemoteObject)) {
return Promise.resolve();
}
return originalReveal(node).then(step3);
});
evalAndDump('inspect($(\'#p1\'))'); evalAndDump('inspect($(\'#p1\'))');
function step2(node, revealPromise) {
if (!(node instanceof SDK.RemoteObject))
return;
revealPromise.then(step3);
}
function step3() { function step3() {
TestRunner.addResult('Selected node id: \'' + UI.panels.elements.selectedDOMNode().getAttribute('id') + '\'.'); TestRunner.addResult('Selected node id: \'' + UI.panels.elements.selectedDOMNode().getAttribute('id') + '\'.');
next(); next();
......
...@@ -24,14 +24,14 @@ ...@@ -24,14 +24,14 @@
let stopRequest; let stopRequest;
let sourceMapRequested; let sourceMapRequested;
let sourceMapRequest = new Promise(resolve => sourceMapRequested = resolve); let sourceMapRequest = new Promise(resolve => sourceMapRequested = resolve);
Host.ResourceLoader.load = function(url, headers, callback){ Host.ResourceLoader.setLoad(function(url, headers, callback){
if (url.endsWith('a.js.map')) { if (url.endsWith('a.js.map')) {
stopRequest = () => callback(404); stopRequest = () => callback(404);
sourceMapRequested(); sourceMapRequested();
return; return;
} }
return origLoad.apply(this, arguments); return origLoad.apply(this, arguments);
} });
await TestRunner.evaluateInPageAnonymously(`function foo() { await TestRunner.evaluateInPageAnonymously(`function foo() {
console.log(42); console.log(42);
......
...@@ -20,13 +20,13 @@ ...@@ -20,13 +20,13 @@
`); `);
TestRunner.addSniffer(SDK.RuntimeModel.prototype, '_inspectRequested', inspect); TestRunner.addSniffer(SDK.RuntimeModel.prototype, '_inspectRequested', inspect);
TestRunner.addSniffer(Common.Revealer, 'reveal', oneRevealPromise, true); const originalReveal = Common.Revealer.reveal;
Common.Revealer.setRevealForTest((node) => {
function oneRevealPromise(node, revealPromise) { if (!(node instanceof SDK.RemoteObject)) {
if (!(node instanceof SDK.RemoteObject)) return Promise.resolve();
return; }
revealPromise.then(updateFocusedNode); return originalReveal(node).then(updateFocusedNode);
} });
function updateFocusedNode() { function updateFocusedNode() {
TestRunner.addResult('Selected node id: \'' + UI.panels.elements.selectedDOMNode().getAttribute('id') + '\'.'); TestRunner.addResult('Selected node id: \'' + UI.panels.elements.selectedDOMNode().getAttribute('id') + '\'.');
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment