Commit 76604066 authored by Charlie Reis's avatar Charlie Reis Committed by Commit Bot

Remove stale TODOs in navigation test.

These have already been fixed in r697145.

Bug: 998284
Change-Id: I53d4770246300cdd0c40716f67de23cf60566312
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819643
Auto-Submit: Charlie Reis <creis@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: default avatarArthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#699251}
parent 343aa477
...@@ -2514,8 +2514,6 @@ IN_PROC_BROWSER_TEST_P(NavigationBaseBrowserTest, ...@@ -2514,8 +2514,6 @@ IN_PROC_BROWSER_TEST_P(NavigationBaseBrowserTest,
// 5. Start history cross-document navigation, cancelling 4. // 5. Start history cross-document navigation, cancelling 4.
EXPECT_TRUE(ExecJs(shell()->web_contents(), "history.back()")); EXPECT_TRUE(ExecJs(shell()->web_contents(), "history.back()"));
// TODO(arthursonzogni): The embedder_url_tracker should update the visible
// URL here.
{ {
EXPECT_EQ(url_b, shell()->web_contents()->GetVisibleURL()); EXPECT_EQ(url_b, shell()->web_contents()->GetVisibleURL());
EXPECT_EQ(url_b, embedder_url_tracker.url()); EXPECT_EQ(url_b, embedder_url_tracker.url());
...@@ -2537,9 +2535,6 @@ IN_PROC_BROWSER_TEST_P(NavigationBaseBrowserTest, ...@@ -2537,9 +2535,6 @@ IN_PROC_BROWSER_TEST_P(NavigationBaseBrowserTest,
EXPECT_EQ(url_b, shell()->web_contents()->GetVisibleURL()); EXPECT_EQ(url_b, shell()->web_contents()->GetVisibleURL());
EXPECT_EQ(url_b, embedder_url_tracker.url()); EXPECT_EQ(url_b, embedder_url_tracker.url());
} }
// TODO(https://crbug.com/998284): The URL tracked by the embedder should have
// been invalidated. At some point, |url_b| should be displayed, not |url_c|.
} }
// Regression test for https://crbug.com/1001283 // Regression test for https://crbug.com/1001283
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment