[ios] Remove TestAppDistributionProvider

Since AppDistributionProvider is a base class with no-op method
implementation, TestAppDistributionProvider is unnecessary (its
method have the same implementation as the base class). Remove
the sub-class.

Bug: none
Change-Id: I73ba4d5e0cb3bf4a39efccb694fa77c421eece57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064187Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743230}

ios/chrome/app/BUILD.gn

@@ -57,7 +57,6 @@ source_set("unit_tests") {
     "//ios/public/provider/chrome/browser:browser",
     "//ios/public/provider/chrome/browser:test_support",
     "//ios/public/provider/chrome/browser/distribution",
-    "//ios/public/provider/chrome/browser/distribution:test_support",
     "//ios/testing:block_swizzler",
     "//ios/web/public/test:test",
     "//testing/gtest",

ios/public/provider/chrome/browser/BUILD.gn

@@ -37,7 +37,7 @@ source_set("test_support") {
   deps = [
     ":browser",
     "//base",
-    "//ios/public/provider/chrome/browser/distribution:test_support",
+    "//ios/public/provider/chrome/browser/distribution",
     "//ios/public/provider/chrome/browser/images:test_support",
     "//ios/public/provider/chrome/browser/mailto:test_support",
     "//ios/public/provider/chrome/browser/omaha:test_support",

ios/public/provider/chrome/browser/distribution/BUILD.gn

@@ -10,16 +10,3 @@ source_set("distribution") {
   ]
   deps = [ "//base" ]
 }
-
-source_set("test_support") {
-  configs += [ "//build/config/compiler:enable_arc" ]
-  testonly = true
-  sources = [
-    "test_app_distribution_provider.h",
-    "test_app_distribution_provider.mm",
-  ]
-  deps = [
-    ":distribution",
-    "//base",
-  ]
-}

ios/public/provider/chrome/browser/distribution/test_app_distribution_provider.h

-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef IOS_PUBLIC_PROVIDER_CHROME_BROWSER_DISTRIBUTION_TEST_APP_DISTRIBUTION_PROVIDER_H_
-#define IOS_PUBLIC_PROVIDER_CHROME_BROWSER_DISTRIBUTION_TEST_APP_DISTRIBUTION_PROVIDER_H_
-
-#import "ios/public/provider/chrome/browser/distribution/app_distribution_provider.h"
-
-#include "base/macros.h"
-#include "base/memory/scoped_refptr.h"
-
-namespace network {
-class SharedURLLoaderFactory;
-}  // namespace network
-
-class TestAppDistributionProvider : public AppDistributionProvider {
- public:
-  TestAppDistributionProvider();
-  ~TestAppDistributionProvider() override;
-
-  // AppDistributionProvider.
-  std::string GetDistributionBrandCode() override;
-  void ScheduleDistributionNotifications(
-      scoped_refptr<network::SharedURLLoaderFactory> shared_url_loader_factory,
-      bool is_first_run) override;
-  void CancelDistributionNotifications() override;
-  bool IsPreFirebaseLegacyUser(int64_t install_date) override;
-
- private:
-  DISALLOW_COPY_AND_ASSIGN(TestAppDistributionProvider);
-};
-
-#endif  // IOS_PUBLIC_PROVIDER_CHROME_BROWSER_DISTRIBUTION_TEST_APP_DISTRIBUTION_PROVIDER_H_

ios/public/provider/chrome/browser/distribution/test_app_distribution_provider.mm

-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#import "ios/public/provider/chrome/browser/distribution/test_app_distribution_provider.h"
-
-#if !defined(__has_feature) || !__has_feature(objc_arc)
-#error "This file requires ARC support."
-#endif
-
-TestAppDistributionProvider::TestAppDistributionProvider() {}
-
-TestAppDistributionProvider::~TestAppDistributionProvider() {}
-
-std::string TestAppDistributionProvider::GetDistributionBrandCode() {
-  return std::string();
-}
-
-void TestAppDistributionProvider::ScheduleDistributionNotifications(
-    scoped_refptr<network::SharedURLLoaderFactory> shared_url_loader_factory,
-    bool is_first_run) {}
-
-void TestAppDistributionProvider::CancelDistributionNotifications() {}
-
-bool TestAppDistributionProvider::IsPreFirebaseLegacyUser(
-    int64_t install_date) {
-  return false;
-}

ios/public/provider/chrome/browser/test_chrome_browser_provider.mm

@@ -7,7 +7,7 @@
 #import <UIKit/UIKit.h>
 
 #include "base/logging.h"
-#include "ios/public/provider/chrome/browser/distribution/test_app_distribution_provider.h"
+#include "ios/public/provider/chrome/browser/distribution/app_distribution_provider.h"
 #include "ios/public/provider/chrome/browser/images/test_branded_image_provider.h"
 #include "ios/public/provider/chrome/browser/mailto/test_mailto_handler_provider.h"
 #include "ios/public/provider/chrome/browser/omaha/test_omaha_service_provider.h"
@@ -27,8 +27,7 @@
 namespace ios {
 
 TestChromeBrowserProvider::TestChromeBrowserProvider()
-    : app_distribution_provider_(
-          std::make_unique<TestAppDistributionProvider>()),
+    : app_distribution_provider_(std::make_unique<AppDistributionProvider>()),
       branded_image_provider_(std::make_unique<TestBrandedImageProvider>()),
       omaha_service_provider_(std::make_unique<TestOmahaServiceProvider>()),
       signin_error_provider_(std::make_unique<SigninErrorProvider>()),