Commit 76a758df authored by Yuki Shiino's avatar Yuki Shiino Committed by Commit Bot

bind-gen: Add missing dependencies to v8_context_snapshot

The build rule of V8 context snapshot is missing some deps,
and this patch supplements them.

Bug: 839389
Change-Id: I875a194718f32d291b582da5071ec28dd992f08c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307849
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: default avatarHitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#790740}
parent 23598835
...@@ -251,3 +251,16 @@ action_with_pydeps("generate_high_entropy_list") { ...@@ -251,3 +251,16 @@ action_with_pydeps("generate_high_entropy_list") {
deps = [ ":web_idl_database" ] deps = [ ":web_idl_database" ]
} }
# Exposes the libraries that affect the resulting blob image of the V8 context
# snapshot.
group("v8_context_snapshot_influential_libs") {
visibility = []
visibility = [ "//tools/v8_context_snapshot/*" ]
public_deps = [
"//third_party/blink/renderer/core",
"//third_party/blink/renderer/modules",
"//third_party/blink/renderer/platform",
]
}
...@@ -64,12 +64,21 @@ if (use_v8_context_snapshot) { ...@@ -64,12 +64,21 @@ if (use_v8_context_snapshot) {
deps = [ ":v8_context_snapshot_generator($v8_snapshot_toolchain)" ] deps = [ ":v8_context_snapshot_generator($v8_snapshot_toolchain)" ]
if (is_component_build) { if (is_component_build) {
# In component builds, this forces the generator to rerun whenever the v8 # In the component build mode, the snapshot should be updated when any of
# shared library is rebuilt. Without it would only regenerate if the # the generator executable or the shared libraries get updated. Note that
# generator itself was rebuilt. # it's possible that some of the shared libraries are updated without
inputs = [ "$root_out_dir/${shlib_prefix}v8${shlib_extension}" ] # having the executable updated.
inputs = [
deps += [ "//v8" ] "$root_out_dir/${shlib_prefix}blink_core${shlib_extension}",
"$root_out_dir/${shlib_prefix}blink_modules${shlib_extension}",
"$root_out_dir/${shlib_prefix}blink_platform${shlib_extension}",
"$root_out_dir/${shlib_prefix}v8${shlib_extension}",
]
deps += [
"//third_party/blink/renderer/bindings:v8_context_snapshot_influential_libs",
"//v8",
]
} }
outputs = [ output_file ] outputs = [ output_file ]
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment