Use legacy getStats() in browser tests.

This attempts to fix various failures in https://crbug.com/999136 due to
our browser tests expecting non-standard stats even after
chrome://webrtc-internals/ was updated to use standard getStats() by
default.

Bug: 999136, 1004239
Change-Id: Ia22ab8ab36213253801109a23b43838ffa24dc8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806677Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696780}

chrome/browser/media/webrtc/webrtc_browsertest_base.cc

@@ -358,6 +358,10 @@ std::string WebRtcTestBase::ExecuteJavascript(
   return result;
 }
 
+void WebRtcTestBase::ChangeToLegacyGetStats(content::WebContents* tab) const {
+  content::ExecuteScriptAsync(tab, "changeToLegacyGetStats()");
+}
+
 void WebRtcTestBase::SetupPeerconnectionWithLocalStream(
     content::WebContents* tab,
     const std::string& certificate_keygen_algorithm) const {

chrome/browser/media/webrtc/webrtc_browsertest_base.h

@@ -116,6 +116,10 @@ class WebRtcTestBase : public InProcessBrowserTest {
   std::string ExecuteJavascript(const std::string& javascript,
                                 content::WebContents* tab_contents) const;
 
+  // TODO(https://crbug.com/1004239): Remove this function as soon as browser
+  // tests stop relying on the legacy getStats() API.
+  void ChangeToLegacyGetStats(content::WebContents* tab) const;
+
   // Sets up a peer connection in the tab and adds the current local stream
   // (which you can prepare by calling one of the GetUserMedia* methods above).
   // Optionally, |certificate_keygen_algorithm| is JavaScript for an

chrome/browser/media/webrtc/webrtc_internals_perf_browsertest.cc

@@ -107,6 +107,9 @@ class WebRtcInternalsPerfBrowserTest : public WebRtcTestBase {
     content::WebContents* webrtc_internals_tab =
         browser()->tab_strip_model()->GetActiveWebContents();
 
+    // TODO(https://crbug.com/1004239): Stop relying on the legacy getStats()
+    // API.
+    ChangeToLegacyGetStats(webrtc_internals_tab);
     test::SleepInJavascript(webrtc_internals_tab, duration_msec);
 
     return std::unique_ptr<base::DictionaryValue>(

content/browser/resources/media/webrtc_internals.js

@@ -124,6 +124,7 @@ function createStatsSelectionOptionElements() {
   const p = document.createElement('p');
 
   const selectElement = document.createElement('select');
+  selectElement.setAttribute('id', 'statsSelectElement');
   selectElement.onchange = () => {
     currentGetStatsMethod = selectElement.value;
     Object.keys(peerConnectionDataStore).forEach(id => {
@@ -176,6 +177,18 @@ function requestLegacyStats() {
   }
 }
 
+/*
+ * Change to use the legacy getStats() API instead. This is used for a
+ * work-around for https://crbug.com/999136.
+ * TODO(https://crbug.com/1004239): Delete this method.
+ */
+function changeToLegacyGetStats() {
+  currentGetStatsMethod = OPTION_GETSTATS_LEGACY;
+  const selectElement = $('statsSelectElement');
+  selectElement.value = currentGetStatsMethod;
+  requestStats();
+}
+
 /**
  * A helper function for getting a peer connection element id.
  *