Allow network quality prefs in Webview

Change-Id: I6da1c02731a1d7b8498ff27abe58212c2eec9bac
Bug: 1126190
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417303Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812384}

android_webview/browser/aw_feature_list_creator.cc

@@ -44,6 +44,7 @@
 #include "components/variations/service/safe_seed_manager.h"
 #include "components/variations/service/variations_service.h"
 #include "content/public/common/content_switch_dependent_feature_overrides.h"
+#include "net/nqe/pref_names.h"
 #include "services/preferences/tracked/segregated_pref_store.h"
 
 namespace android_webview {
@@ -80,6 +81,7 @@ const char* const kPersistentPrefsAllowlist[] = {
     // Unsent logs metadata.
     metrics::prefs::kMetricsInitialLogsMetadata,
     metrics::prefs::kMetricsOngoingLogsMetadata,
+    net::nqe::kNetworkQualities,
     // Current and past country codes, to filter variations studies by country.
     variations::prefs::kVariationsCountry,
     variations::prefs::kVariationsPermanentConsistencyCountry,

net/BUILD.gn

@@ -802,6 +802,8 @@ component("net") {
       "nqe/observation_buffer.cc",
       "nqe/observation_buffer.h",
       "nqe/peer_to_peer_connections_count_observer.h",
+      "nqe/pref_names.cc",
+      "nqe/pref_names.h",
       "nqe/rtt_throughput_estimates_observer.h",
       "nqe/socket_watcher.cc",
       "nqe/socket_watcher.h",

net/nqe/pref_names.cc

+// Copyright 2020 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/nqe/pref_names.h"
+
+namespace net {
+
+namespace nqe {
+
+const char kNetworkQualities[] = "net.network_qualities";
+
+}  // namespace nqe
+
+}  // namespace net

net/nqe/pref_names.h

+// Copyright 2020 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_NQE_PREF_NAMES_H_
+#define NET_NQE_PREF_NAMES_H_
+
+#include "net/base/net_export.h"
+
+namespace net {
+
+namespace nqe {
+
+// Prefs for persisting network qualities.
+NET_EXPORT_PRIVATE extern const char kNetworkQualities[];
+
+}  // namespace nqe
+
+}  // namespace net
+
+#endif  // NET_NQE_PREF_NAMES_H_

services/network/network_qualities_pref_delegate.cc

@@ -16,12 +16,10 @@
 #include "components/prefs/pref_service.h"
 #include "net/http/http_server_properties.h"
 #include "net/nqe/network_quality_estimator.h"
+#include "net/nqe/pref_names.h"
 
 namespace {
 
-// Prefs for persisting network qualities.
-const char kNetworkQualities[] = "net.network_qualities";
-
 // PrefDelegateImpl writes the provided dictionary value to the network quality
 // estimator prefs on the disk.
 class PrefDelegateImpl
@@ -29,7 +27,7 @@ class PrefDelegateImpl
  public:
   // |pref_service| is used to read and write prefs from/to the disk.
   explicit PrefDelegateImpl(PrefService* pref_service)
-      : pref_service_(pref_service), path_(kNetworkQualities) {
+      : pref_service_(pref_service), path_(net::nqe::kNetworkQualities) {
     DCHECK(pref_service_);
   }
   ~PrefDelegateImpl() override {}
@@ -102,7 +100,7 @@ void NetworkQualitiesPrefDelegate::ClearPrefs() {
 
 // static
 void NetworkQualitiesPrefDelegate::RegisterPrefs(PrefRegistrySimple* registry) {
-  registry->RegisterDictionaryPref(kNetworkQualities);
+  registry->RegisterDictionaryPref(net::nqe::kNetworkQualities);
 }
 
 std::map<net::nqe::internal::NetworkID,