Commit 76b93d2d authored by Sahel Sharify's avatar Sahel Sharify Committed by Commit Bot

Don't suppress Showpress after a GFC followed by Tap down suppression

Showpress should get forwarded after a GFC followed by Tap down suppression.

Bug: 842221
Change-Id: I60beaf3296557ec8c3d3d25b627f272b82114eed
Reviewed-on: https://chromium-review.googlesource.com/1055653Reviewed-by: default avatarDave Tapuska <dtapuska@chromium.org>
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557958}
parent abd7806b
...@@ -80,7 +80,6 @@ bool FlingController::ShouldForwardForTapSuppression( ...@@ -80,7 +80,6 @@ bool FlingController::ShouldForwardForTapSuppression(
} }
return true; return true;
case WebInputEvent::kGestureTapDown: case WebInputEvent::kGestureTapDown:
case WebInputEvent::kGestureShowPress:
case WebInputEvent::kGestureTapUnconfirmed: case WebInputEvent::kGestureTapUnconfirmed:
case WebInputEvent::kGestureTapCancel: case WebInputEvent::kGestureTapCancel:
case WebInputEvent::kGestureTap: case WebInputEvent::kGestureTap:
......
...@@ -505,7 +505,8 @@ TEST_F(FlingControllerTest, MiddleClickAutoScrollFling) { ...@@ -505,7 +505,8 @@ TEST_F(FlingControllerTest, MiddleClickAutoScrollFling) {
EXPECT_FALSE(FlingInProgress()); EXPECT_FALSE(FlingInProgress());
} }
TEST_F(FlingControllerTest, NoLongPressSuppressionAfterTapDownSuppression) { TEST_F(FlingControllerTest,
NoShowPressOrLongPressSuppressionAfterTapDownSuppression) {
base::TimeTicks progress_time = base::TimeTicks::Now(); base::TimeTicks progress_time = base::TimeTicks::Now();
SimulateFlingStart(blink::kWebGestureDeviceTouchscreen, SimulateFlingStart(blink::kWebGestureDeviceTouchscreen,
gfx::Vector2dF(1000, 0)); gfx::Vector2dF(1000, 0));
...@@ -527,6 +528,13 @@ TEST_F(FlingControllerTest, NoLongPressSuppressionAfterTapDownSuppression) { ...@@ -527,6 +528,13 @@ TEST_F(FlingControllerTest, NoLongPressSuppressionAfterTapDownSuppression) {
EXPECT_TRUE(fling_controller_->FilterGestureEvent( EXPECT_TRUE(fling_controller_->FilterGestureEvent(
GestureEventWithLatencyInfo(tap_down))); GestureEventWithLatencyInfo(tap_down)));
// The GestureShowPress shouldn't get filtered.
WebGestureEvent show_press(WebInputEvent::kGestureShowPress, 0,
base::TimeTicks::Now(),
blink::kWebGestureDeviceTouchscreen);
EXPECT_FALSE(fling_controller_->FilterGestureEvent(
GestureEventWithLatencyInfo(show_press)));
// The GestureLongPress shouldn't get filtered. // The GestureLongPress shouldn't get filtered.
WebGestureEvent long_press(WebInputEvent::kGestureLongPress, 0, WebGestureEvent long_press(WebInputEvent::kGestureLongPress, 0,
base::TimeTicks::Now(), base::TimeTicks::Now(),
......
...@@ -24,7 +24,6 @@ bool TouchscreenTapSuppressionController::FilterTapEvent( ...@@ -24,7 +24,6 @@ bool TouchscreenTapSuppressionController::FilterTapEvent(
case WebInputEvent::kGestureTapDown: case WebInputEvent::kGestureTapDown:
return ShouldSuppressTapDown(); return ShouldSuppressTapDown();
case WebInputEvent::kGestureShowPress:
case WebInputEvent::kGestureTapUnconfirmed: case WebInputEvent::kGestureTapUnconfirmed:
case WebInputEvent::kGestureTapCancel: case WebInputEvent::kGestureTapCancel:
case WebInputEvent::kGestureTap: case WebInputEvent::kGestureTap:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment