Commit 77097db7 authored by Lutz Justen's avatar Lutz Justen Committed by Commit Bot

Kerberos: Fix use-after-delete issue

BUG=None
TEST=Tested manually that notifications pop up reauth dialog

Change-Id: I64e88864f9e028adf91eb3012fca0b7864816480
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706429Reviewed-by: default avatarMaksim Ivanov <emaxx@chromium.org>
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#678246}
parent fe01e966
......@@ -826,11 +826,13 @@ void KerberosCredentialsManager::OnTicketExpiryNotificationClick(
const std::string& principal_name) {
// TODO(https://crbug.com/952245): Right now, the reauth dialog is tied to the
// settings. Consider creating a standalone reauth dialog.
kerberos_ticket_expiry_notification::Close(primary_profile_);
chrome::SettingsWindowManager::GetInstance()->ShowOSSettings(
primary_profile_,
chrome::kKerberosAccountsSubPage + std::string("?kerberos_reauth=") +
net::EscapeQueryParamValue(principal_name, false /* use_plus */));
// Close last! |principal_name| is owned by the notification.
kerberos_ticket_expiry_notification::Close(primary_profile_);
}
} // namespace chromeos
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment