Commit 771622a8 authored by Mario Sanchez Prada's avatar Mario Sanchez Prada Committed by Commit Bot

Update documentation in //components/signin/core/browser/identity_utils.h

Rewrite the header as per the after-landing suggestions in CL1346093.

Bug: 907995
Change-Id: Iaecf3cd6257846f2012c7b42b97ffb844f4b45d7
Reviewed-on: https://chromium-review.googlesource.com/c/1349250Reviewed-by: default avatarColin Blundell <blundell@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#610557}
parent 5834856c
...@@ -2,9 +2,12 @@ ...@@ -2,9 +2,12 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// //
// Collection of utility functions to support migrating different consumers of // Functions that are shared between the Identity Service implementation and its
// the SigninManager component to the Identity service, which will eventually be // consumers. Currently in //components/signin because they are used by classes
// migrated to //services/identity once the SigninManager class gets removed. // in this component, which cannot depend on //services/identity to avoid a
// dependency cycle. When these classes have no direct consumers and are moved
// to //services/identity, these functions should correspondingly be moved to
// //services/identity/public/cpp.
#ifndef COMPONENTS_SIGNIN_CORE_BROWSER_IDENTITY_UTILS_H_ #ifndef COMPONENTS_SIGNIN_CORE_BROWSER_IDENTITY_UTILS_H_
#define COMPONENTS_SIGNIN_CORE_BROWSER_IDENTITY_UTILS_H_ #define COMPONENTS_SIGNIN_CORE_BROWSER_IDENTITY_UTILS_H_
...@@ -14,6 +17,9 @@ ...@@ -14,6 +17,9 @@
namespace identity { namespace identity {
// Returns true if the username is allowed based on the pattern string. // Returns true if the username is allowed based on the pattern string.
//
// NOTE: Can be moved to //services/identity/public/cpp once SigninManager is
// moved to //services/identity.
bool IsUsernameAllowedByPattern(base::StringPiece username, bool IsUsernameAllowedByPattern(base::StringPiece username,
base::StringPiece pattern); base::StringPiece pattern);
} // namespace identity } // namespace identity
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment