Fix a static initializer issue in LocalSiteCharImpl.

TimeDeltaToInternalRepresentation can't return a constexpr because it
uses TimeDelta::InSeconds which can't be evaluated at compile time,
remove the |kZeroIntervalInternalRepresentation| value as this doesn't
provide any clear value here.

Bug: 773382,846431
Change-Id: I6b2df260742c239cc664e8476c726d4ba15731dc
Reviewed-on: https://chromium-review.googlesource.com/1072347
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561608}

chrome/browser/resource_coordinator/local_site_characteristics_data_impl.cc

@@ -35,12 +35,6 @@ std::vector<SiteCharacteristicsFeatureProto*> GetAllFeaturesFromProto(
 
 }  // namespace
 
-// static:
-const int64_t
-    LocalSiteCharacteristicsDataImpl::kZeroIntervalInternalRepresentation =
-        LocalSiteCharacteristicsDataImpl::TimeDeltaToInternalRepresentation(
-            base::TimeDelta());
-
 void LocalSiteCharacteristicsDataImpl::NotifySiteLoaded() {
   DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);
   // Update the last loaded time when this origin gets loaded for the first
@@ -203,8 +197,11 @@ void LocalSiteCharacteristicsDataImpl::
     InitSiteCharacteristicsFeatureProtoWithDefaultValues(
         SiteCharacteristicsFeatureProto* proto) {
   DCHECK_NE(nullptr, proto);
-  proto->set_observation_duration(kZeroIntervalInternalRepresentation);
-  proto->set_use_timestamp(kZeroIntervalInternalRepresentation);
+  static const auto zero_interval =
+      LocalSiteCharacteristicsDataImpl::TimeDeltaToInternalRepresentation(
+          base::TimeDelta());
+  proto->set_observation_duration(zero_interval);
+  proto->set_use_timestamp(zero_interval);
 }
 
 void LocalSiteCharacteristicsDataImpl::InitWithDefaultValues(
@@ -219,7 +216,9 @@ void LocalSiteCharacteristicsDataImpl::InitWithDefaultValues(
 
   if (!only_init_uninitialized_fields ||
       !site_characteristics_.has_last_loaded()) {
-    site_characteristics_.set_last_loaded(kZeroIntervalInternalRepresentation);
+    site_characteristics_.set_last_loaded(
+        LocalSiteCharacteristicsDataImpl::TimeDeltaToInternalRepresentation(
+            base::TimeDelta()));
   }
 }
 
@@ -274,7 +273,9 @@ void LocalSiteCharacteristicsDataImpl::NotifyFeatureUsage(
 
   feature_proto->set_use_timestamp(
       TimeDeltaToInternalRepresentation(GetTickDeltaSinceEpoch()));
-  feature_proto->set_observation_duration(kZeroIntervalInternalRepresentation);
+  feature_proto->set_observation_duration(
+      LocalSiteCharacteristicsDataImpl::TimeDeltaToInternalRepresentation(
+          base::TimeDelta()));
 }
 
 void LocalSiteCharacteristicsDataImpl::OnInitCallback(
@@ -300,13 +301,17 @@ void LocalSiteCharacteristicsDataImpl::OnInitCallback(
           (*this_features_iter)
               ->set_use_timestamp((*db_features_iter)->use_timestamp());
           (*this_features_iter)
-              ->set_observation_duration(kZeroIntervalInternalRepresentation);
+              ->set_observation_duration(
+                  LocalSiteCharacteristicsDataImpl::
+                      TimeDeltaToInternalRepresentation(base::TimeDelta()));
         } else {
           // Else, add the observation duration from the database to the
           // in-memory observation duration.
           if (!(*this_features_iter)->has_observation_duration()) {
             (*this_features_iter)
-                ->set_observation_duration(kZeroIntervalInternalRepresentation);
+                ->set_observation_duration(
+                    LocalSiteCharacteristicsDataImpl::
+                        TimeDeltaToInternalRepresentation(base::TimeDelta()));
           }
           IncrementFeatureObservationDuration(
               (*this_features_iter),

chrome/browser/resource_coordinator/local_site_characteristics_data_impl.h

@@ -121,8 +121,6 @@ class LocalSiteCharacteristicsDataImpl
   FRIEND_TEST_ALL_PREFIXES(LocalSiteCharacteristicsDataImplTest,
                            LateAsyncReadDoesntBypassClearEvent);
 
-  static const int64_t kZeroIntervalInternalRepresentation;
-
   // Add |extra_observation_duration| to the observation window of a given
   // feature if it hasn't been used yet, do nothing otherwise.
   static void IncrementFeatureObservationDuration(