Commit 7722bedf authored by Rayan Kanso's avatar Rayan Kanso Committed by Commit Bot

Fix IDL compiler dictionary ImplementedAs bug

The dependencies in the build rule use the name of the idl file
containing the dictionary defintion. For the cases where ImplementedAs
is used, the build rule will fail since the generated file matches the
ImplementedAs value.

This CL changes the file name of the generated dictionary implementation
to match the idl name rather than the ImplementedAs name.

Bug: 839847
Change-Id: Ic5d9dfc82ba90188e26f1206465eb790dc8a193b
Reviewed-on: https://chromium-review.googlesource.com/1044217
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: default avatarHitoshi Yoshida <peria@chromium.org>
Reviewed-by: default avatarYuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558291}
parent b710e603
......@@ -282,8 +282,7 @@ class CodeGeneratorDictionaryImpl(CodeGeneratorV8Base):
template_context['header_includes'].add(self.info_provider.include_path_for_export)
template_context['header_includes'].update(
interface_info.get('additional_header_includes', []))
header_path, cpp_path = self.output_paths(
cpp_name(dictionary), interface_info)
header_path, cpp_path = self.output_paths(definition_name, interface_info)
template_context['this_include_header_path'] = posixpath.basename(header_path)
header_text, cpp_text = self.render_template(
include_paths, header_template, cpp_template, template_context)
......
......@@ -8,7 +8,7 @@
// DO NOT MODIFY!
// clang-format off
#include "test_dictionary_derived_implemented_as.h"
#include "test_dictionary_derived.h"
namespace blink {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment