Commit 772a5b29 authored by hans@chromium.org's avatar hans@chromium.org

Clean-up inline members of nested classes (ipc/)

Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.

The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.

BUG=139346


Review URL: https://chromiumcodereview.appspot.com/10825275

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150891 0039d316-1c4b-4281-b951-d872f2087c98
parent 7e834f06
...@@ -173,6 +173,10 @@ void ChannelProxy::Context::OnChannelClosed() { ...@@ -173,6 +173,10 @@ void ChannelProxy::Context::OnChannelClosed() {
Release(); Release();
} }
void ChannelProxy::Context::Clear() {
listener_ = NULL;
}
// Called on the IPC::Channel thread // Called on the IPC::Channel thread
void ChannelProxy::Context::OnSendMessage(scoped_ptr<Message> message) { void ChannelProxy::Context::OnSendMessage(scoped_ptr<Message> message) {
if (!channel_.get()) { if (!channel_.get()) {
......
...@@ -226,7 +226,7 @@ class IPC_EXPORT ChannelProxy : public Sender { ...@@ -226,7 +226,7 @@ class IPC_EXPORT ChannelProxy : public Sender {
// Called on the consumers thread when the ChannelProxy is closed. At that // Called on the consumers thread when the ChannelProxy is closed. At that
// point the consumer is telling us that they don't want to receive any // point the consumer is telling us that they don't want to receive any
// more messages, so we honor that wish by forgetting them! // more messages, so we honor that wish by forgetting them!
virtual void Clear() { listener_ = NULL; } virtual void Clear();
private: private:
friend class ChannelProxy; friend class ChannelProxy;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment