Commit 7741ab49 authored by tfarina's avatar tfarina Committed by Commit bot

tools/gn: forward declare some base types in trace.h

CommandLine and FilePath are being passed by reference, so they can be
forward declared and their header includes be moved to the source file
instead.

BUG=None
TEST=gn gen + gn_unittests
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1492813002

Cr-Commit-Position: refs/heads/master@{#363056}
parent dfefa298
...@@ -9,6 +9,8 @@ ...@@ -9,6 +9,8 @@
#include <sstream> #include <sstream>
#include <vector> #include <vector>
#include "base/command_line.h"
#include "base/files/file_path.h"
#include "base/files/file_util.h" #include "base/files/file_util.h"
#include "base/json/string_escape.h" #include "base/json/string_escape.h"
#include "base/logging.h" #include "base/logging.h"
......
...@@ -7,14 +7,17 @@ ...@@ -7,14 +7,17 @@
#include <string> #include <string>
#include "base/command_line.h"
#include "base/files/file_path.h"
#include "base/macros.h" #include "base/macros.h"
#include "base/threading/platform_thread.h" #include "base/threading/platform_thread.h"
#include "base/time/time.h" #include "base/time/time.h"
class Label; class Label;
namespace base {
class CommandLine;
class FilePath;
}
class TraceItem { class TraceItem {
public: public:
enum Type { enum Type {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment