Commit 777e8b65 authored by Nico Weber's avatar Nico Weber Committed by Commit Bot

Add explicit fallthrough statements in core/svg.

No behavior change.

Bug: 177475
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ie21f59f1b5b18663d29c3fae5c331184ae90b9b9
Reviewed-on: https://chromium-review.googlesource.com/894302Reviewed-by: default avatarStephen Chenney <schenney@chromium.org>
Reviewed-by: default avatarFlorin Malita <fmalita@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533085}
parent 04d4e6f3
...@@ -196,12 +196,12 @@ PathSegmentData SVGPathStringSource::ParseSegment() { ...@@ -196,12 +196,12 @@ PathSegmentData SVGPathStringSource::ParseSegment() {
case kPathSegCurveToCubicAbs: case kPathSegCurveToCubicAbs:
segment.point1.SetX(ParseNumberWithError()); segment.point1.SetX(ParseNumberWithError());
segment.point1.SetY(ParseNumberWithError()); segment.point1.SetY(ParseNumberWithError());
/* fall through */ FALLTHROUGH;
case kPathSegCurveToCubicSmoothRel: case kPathSegCurveToCubicSmoothRel:
case kPathSegCurveToCubicSmoothAbs: case kPathSegCurveToCubicSmoothAbs:
segment.point2.SetX(ParseNumberWithError()); segment.point2.SetX(ParseNumberWithError());
segment.point2.SetY(ParseNumberWithError()); segment.point2.SetY(ParseNumberWithError());
/* fall through */ FALLTHROUGH;
case kPathSegMoveToRel: case kPathSegMoveToRel:
case kPathSegMoveToAbs: case kPathSegMoveToAbs:
case kPathSegLineToRel: case kPathSegLineToRel:
......
...@@ -19,9 +19,9 @@ ...@@ -19,9 +19,9 @@
#include "core/svg/SVGTransformDistance.h" #include "core/svg/SVGTransformDistance.h"
#include <math.h>
#include "platform/geometry/FloatPoint.h" #include "platform/geometry/FloatPoint.h"
#include "platform/geometry/FloatSize.h" #include "platform/geometry/FloatSize.h"
#include <math.h>
namespace blink { namespace blink {
...@@ -48,6 +48,7 @@ SVGTransformDistance::SVGTransformDistance(SVGTransform* from_svg_transform, ...@@ -48,6 +48,7 @@ SVGTransformDistance::SVGTransformDistance(SVGTransform* from_svg_transform,
switch (transform_type_) { switch (transform_type_) {
case kSvgTransformMatrix: case kSvgTransformMatrix:
NOTREACHED(); NOTREACHED();
FALLTHROUGH;
case kSvgTransformUnknown: case kSvgTransformUnknown:
break; break;
case kSvgTransformRotate: { case kSvgTransformRotate: {
...@@ -85,6 +86,7 @@ SVGTransformDistance SVGTransformDistance::ScaledDistance( ...@@ -85,6 +86,7 @@ SVGTransformDistance SVGTransformDistance::ScaledDistance(
switch (transform_type_) { switch (transform_type_) {
case kSvgTransformMatrix: case kSvgTransformMatrix:
NOTREACHED(); NOTREACHED();
FALLTHROUGH;
case kSvgTransformUnknown: case kSvgTransformUnknown:
return SVGTransformDistance(); return SVGTransformDistance();
case kSvgTransformRotate: case kSvgTransformRotate:
...@@ -122,6 +124,7 @@ SVGTransform* SVGTransformDistance::AddSVGTransforms(SVGTransform* first, ...@@ -122,6 +124,7 @@ SVGTransform* SVGTransformDistance::AddSVGTransforms(SVGTransform* first,
switch (first->TransformType()) { switch (first->TransformType()) {
case kSvgTransformMatrix: case kSvgTransformMatrix:
NOTREACHED(); NOTREACHED();
FALLTHROUGH;
case kSvgTransformUnknown: case kSvgTransformUnknown:
return transform; return transform;
case kSvgTransformRotate: { case kSvgTransformRotate: {
...@@ -168,6 +171,7 @@ SVGTransform* SVGTransformDistance::AddToSVGTransform( ...@@ -168,6 +171,7 @@ SVGTransform* SVGTransformDistance::AddToSVGTransform(
switch (transform_type_) { switch (transform_type_) {
case kSvgTransformMatrix: case kSvgTransformMatrix:
NOTREACHED(); NOTREACHED();
FALLTHROUGH;
case kSvgTransformUnknown: case kSvgTransformUnknown:
return SVGTransform::Create(); return SVGTransform::Create();
case kSvgTransformTranslate: { case kSvgTransformTranslate: {
...@@ -204,6 +208,7 @@ float SVGTransformDistance::Distance() const { ...@@ -204,6 +208,7 @@ float SVGTransformDistance::Distance() const {
switch (transform_type_) { switch (transform_type_) {
case kSvgTransformMatrix: case kSvgTransformMatrix:
NOTREACHED(); NOTREACHED();
FALLTHROUGH;
case kSvgTransformUnknown: case kSvgTransformUnknown:
return 0; return 0;
case kSvgTransformRotate: case kSvgTransformRotate:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment