Commit 77855273 authored by Austin Eng's avatar Austin Eng Committed by Commit Bot

Skip SharedImageGLBackingProduceDawnTest on Win7

Dawn is not supported on Win7. The tests were inadvertently enabled
in https://chromium-review.googlesource.com/c/chromium/src/+/2480584
which changed test set up. Now, the TestGPUServiceHolder is not
created at all on unsupported platforms. Use it as a signal to skip
the test.

Tbr: cwallez@chromium.org
Bug: 1139941
Change-Id: I68b4fcf733ca83978b544f7d065866760fc056db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485674Reviewed-by: default avatarAustin Eng <enga@chromium.org>
Reviewed-by: default avatarCorentin Wallez <cwallez@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818542}
parent eae6c5bb
...@@ -74,7 +74,9 @@ class SharedImageGLBackingProduceDawnTest : public WebGPUTest { ...@@ -74,7 +74,9 @@ class SharedImageGLBackingProduceDawnTest : public WebGPUTest {
bool ShouldSkipTest() { bool ShouldSkipTest() {
// Windows is the only platform enabled passthrough in this test. // Windows is the only platform enabled passthrough in this test.
#if defined(OS_WIN) #if defined(OS_WIN)
return false; // Skip the test if there is no GPU service holder. It is not created if
// Dawn is not supported on the platform (Win7).
return GetGpuServiceHolder() == nullptr;
#else #else
return true; return true;
#endif // defined(OS_WIN) #endif // defined(OS_WIN)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment