[updater] add tryjobs for chromium updater.

Configure them to:
1. run on any changes to //chrome/updater.
2. list under `Choose Tryjobs` for luci.chromium.try

Bug: 1120836
Change-Id: I519c632b6b99fa41f256b2f6a70d8e300f4941a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536032
Commit-Queue: Anjali Doneria <adoneria@google.com>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827428}

infra/config/generated/commit-queue.cfg

@@ -1330,6 +1330,12 @@ config_groups {
         name: "chromium/try/mac-swangle-chromium-try-x64"
         includable_only: true
       }
+      builders {
+        name: "chromium/try/mac-updater-try-builder-rel"
+        location_regexp: ".+/[+]/chrome/updater/.+"
+        location_regexp_exclude: ".+/[+]/docs/.+"
+        location_regexp_exclude: ".+/[+]/infra/config/.+"
+      }
       builders {
         name: "chromium/try/mac10.12-blink-rel"
         includable_only: true
@@ -1508,6 +1514,12 @@ config_groups {
         name: "chromium/try/win-swangle-try-x86"
         includable_only: true
       }
+      builders {
+        name: "chromium/try/win-updater-try-builder-rel"
+        location_regexp: ".+/[+]/chrome/updater/.+"
+        location_regexp_exclude: ".+/[+]/docs/.+"
+        location_regexp_exclude: ".+/[+]/infra/config/.+"
+      }
       builders {
         name: "chromium/try/win10-blink-rel"
         includable_only: true

infra/config/generated/cq-builders.md

@@ -293,6 +293,11 @@ builder.
   * [`//chrome/browser/vr/.+`](https://cs.chromium.org/chromium/src/chrome/browser/vr/)
   * [`//content/browser/xr/.+`](https://cs.chromium.org/chromium/src/content/browser/xr/)
 
+* [mac-updater-try-builder-rel](https://ci.chromium.org/p/chromium/builders/try/mac-updater-try-builder-rel) ([definition](https://cs.chromium.org/search?q=package:%5Echromium$+file:/cq.star$+-file:/beta/+-file:/stable/+mac-updater-try-builder-rel)) ([matching builders](https://cs.chromium.org/search?q=+file:trybots.py+mac-updater-try-builder-rel))
+
+  Path regular expressions:
+  * [`//chrome/updater/.+`](https://cs.chromium.org/chromium/src/chrome/updater/)
+
 * [mac_optional_gpu_tests_rel](https://ci.chromium.org/p/chromium/builders/try/mac_optional_gpu_tests_rel) ([definition](https://cs.chromium.org/search?q=package:%5Echromium$+file:/cq.star$+-file:/beta/+-file:/stable/+mac_optional_gpu_tests_rel)) ([matching builders](https://cs.chromium.org/search?q=+file:trybots.py+mac_optional_gpu_tests_rel))
 
   Path regular expressions:
@@ -312,6 +317,11 @@ builder.
   * [`//tools/clang/scripts/update.py`](https://cs.chromium.org/search?q=package:%5Echromium$+file:tools/clang/scripts/update.py)
   * [`//ui/gl/.+`](https://cs.chromium.org/chromium/src/ui/gl/)
 
+* [win-updater-try-builder-rel](https://ci.chromium.org/p/chromium/builders/try/win-updater-try-builder-rel) ([definition](https://cs.chromium.org/search?q=package:%5Echromium$+file:/cq.star$+-file:/beta/+-file:/stable/+win-updater-try-builder-rel)) ([matching builders](https://cs.chromium.org/search?q=+file:trybots.py+win-updater-try-builder-rel))
+
+  Path regular expressions:
+  * [`//chrome/updater/.+`](https://cs.chromium.org/chromium/src/chrome/updater/)
+
 * [win7-rel](https://ci.chromium.org/p/chromium/builders/try/win7-rel) ([definition](https://cs.chromium.org/search?q=package:%5Echromium$+file:/cq.star$+-file:/beta/+-file:/stable/+win7-rel)) ([matching builders](https://cs.chromium.org/search?q=+file:trybots.py+win7-rel))
 
   Path regular expressions:

infra/config/generated/cr-buildbucket.cfg

@@ -36388,6 +36388,59 @@ buckets {
         }
       }
     }
+    builders {
+      name: "mac-updater-try-builder-rel"
+      swarming_host: "chromium-swarm.appspot.com"
+      swarming_tags: "vpython:native-python-wrapper"
+      dimensions: "builderless:1"
+      dimensions: "cpu:x86-64"
+      dimensions: "os:Mac"
+      dimensions: "pool:luci.chromium.try"
+      exe {
+        cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"
+        cipd_version: "refs/heads/master"
+        cmd: "recipes"
+      }
+      properties: "{\"$build/goma\":{\"rpc_extra_params\":\"?prod\",\"server_host\":\"goma.chromium.org\",\"use_luci_auth\":true},\"$kitchen\":{\"devshell\":true,\"git_auth\":true},\"$recipe_engine/isolated\":{\"server\":\"https://isolateserver.appspot.com\"},\"builder_group\":\"tryserver.chromium.updater\",\"recipe\":\"chromium_trybot\"}"
+      execution_timeout_secs: 14400
+      expiration_secs: 7200
+      caches {
+        name: "win_toolchain"
+        path: "win_toolchain"
+      }
+      build_numbers: YES
+      service_account: "chromium-try-builder@chops-service-accounts.iam.gserviceaccount.com"
+      task_template_canary_percentage {
+        value: 5
+      }
+      experiments {
+        key: "chromium.resultdb.result_sink"
+        value: 50
+      }
+      experiments {
+        key: "luci.use_realms"
+        value: 100
+      }
+      resultdb {
+        enable: true
+        bq_exports {
+          project: "luci-resultdb"
+          dataset: "chromium"
+          table: "try_test_results"
+          test_results {}
+        }
+        bq_exports {
+          project: "luci-resultdb"
+          dataset: "chromium"
+          table: "gpu_try_test_results"
+          test_results {
+            predicate {
+              test_id_regexp: "ninja://(chrome/test:|content/test:fuchsia_)telemetry_gpu_integration_test/.+"
+            }
+          }
+        }
+      }
+    }
     builders {
       name: "mac10.12-blink-rel"
       swarming_host: "chromium-swarm.appspot.com"
@@ -38507,6 +38560,61 @@ buckets {
         }
       }
     }
+    builders {
+      name: "win-updater-try-builder-rel"
+      swarming_host: "chromium-swarm.appspot.com"
+      swarming_tags: "vpython:native-python-wrapper"
+      dimensions: "builderless:1"
+      dimensions: "cores:8"
+      dimensions: "cpu:x86-64"
+      dimensions: "os:Windows-10"
+      dimensions: "pool:luci.chromium.try"
+      dimensions: "ssd:0"
+      exe {
+        cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"
+        cipd_version: "refs/heads/master"
+        cmd: "recipes"
+      }
+      properties: "{\"$build/goma\":{\"enable_ats\":true,\"rpc_extra_params\":\"?prod\",\"server_host\":\"goma.chromium.org\",\"use_luci_auth\":true},\"$kitchen\":{\"devshell\":true,\"git_auth\":true},\"$recipe_engine/isolated\":{\"server\":\"https://isolateserver.appspot.com\"},\"builder_group\":\"tryserver.chromium.updater\",\"recipe\":\"chromium_trybot\"}"
+      execution_timeout_secs: 14400
+      expiration_secs: 7200
+      caches {
+        name: "win_toolchain"
+        path: "win_toolchain"
+      }
+      build_numbers: YES
+      service_account: "chromium-try-builder@chops-service-accounts.iam.gserviceaccount.com"
+      task_template_canary_percentage {
+        value: 5
+      }
+      experiments {
+        key: "chromium.resultdb.result_sink"
+        value: 50
+      }
+      experiments {
+        key: "luci.use_realms"
+        value: 100
+      }
+      resultdb {
+        enable: true
+        bq_exports {
+          project: "luci-resultdb"
+          dataset: "chromium"
+          table: "try_test_results"
+          test_results {}
+        }
+        bq_exports {
+          project: "luci-resultdb"
+          dataset: "chromium"
+          table: "gpu_try_test_results"
+          test_results {
+            predicate {
+              test_id_regexp: "ninja://(chrome/test:|content/test:fuchsia_)telemetry_gpu_integration_test/.+"
+            }
+          }
+        }
+      }
+    }
     builders {
       name: "win10-blink-rel"
       swarming_host: "chromium-swarm.appspot.com"

infra/config/generated/luci-milo.cfg

@@ -1954,6 +1954,9 @@ consoles {
   builders {
     name: "buildbucket/luci.chromium.try/mac-rel"
   }
+  builders {
+    name: "buildbucket/luci.chromium.try/mac-updater-try-builder-rel"
+  }
   builders {
     name: "buildbucket/luci.chromium.try/mac_chromium_compile_dbg_ng"
   }
@@ -1963,6 +1966,9 @@ consoles {
   builders {
     name: "buildbucket/luci.chromium.try/win-libfuzzer-asan-rel"
   }
+  builders {
+    name: "buildbucket/luci.chromium.try/win-updater-try-builder-rel"
+  }
   builders {
     name: "buildbucket/luci.chromium.try/win10_chromium_x64_rel_ng"
   }
@@ -12161,6 +12167,9 @@ consoles {
   builders {
     name: "buildbucket/luci.chromium.try/mac-swangle-chromium-try-x64"
   }
+  builders {
+    name: "buildbucket/luci.chromium.try/mac-updater-try-builder-rel"
+  }
   builders {
     name: "buildbucket/luci.chromium.try/mac10.12-blink-rel"
   }
@@ -12278,6 +12287,9 @@ consoles {
   builders {
     name: "buildbucket/luci.chromium.try/win-swangle-try-x86"
   }
+  builders {
+    name: "buildbucket/luci.chromium.try/win-updater-try-builder-rel"
+  }
   builders {
     name: "buildbucket/luci.chromium.try/win10-blink-rel"
   }
@@ -13147,6 +13159,17 @@ consoles {
   }
   builder_view_only: true
 }
+consoles {
+  id: "tryserver.chromium.updater"
+  name: "tryserver.chromium.updater"
+  builders {
+    name: "buildbucket/luci.chromium.try/mac-updater-try-builder-rel"
+  }
+  builders {
+    name: "buildbucket/luci.chromium.try/win-updater-try-builder-rel"
+  }
+  builder_view_only: true
+}
 consoles {
   id: "tryserver.chromium.win"
   name: "tryserver.chromium.win"

infra/config/lib/try.star

@@ -410,6 +410,40 @@ def chromium_swangle_windows_builder(*, name, **kwargs):
         **kwargs
     )
 
+def chromium_updater_builder(
+        *,
+        name,
+        executable = "recipe:chromium_trybot",
+        goma_backend,
+        os,
+        **kwargs):
+    return try_builder(
+        name = name,
+        builder_group = "tryserver.chromium.updater",
+        builderless = True,
+        executable = executable,
+        goma_backend = goma_backend,
+        os = os,
+        **kwargs
+    )
+
+def chromium_updater_mac_builder(*, name, **kwargs):
+    return chromium_updater_builder(
+        name = name,
+        cores = None,
+        goma_backend = builders.goma.backend.RBE_PROD,
+        os = builders.os.MAC_ANY,
+        **kwargs
+    )
+
+def chromium_updater_win_builder(*, name, **kwargs):
+    return chromium_updater_builder(
+        name = name,
+        goma_backend = builders.goma.backend.RBE_PROD,
+        os = builders.os.WINDOWS_DEFAULT,
+        **kwargs
+    )
+
 def chromium_win_builder(
         *,
         name,
@@ -495,6 +529,8 @@ try_ = struct(
     chromium_swangle_linux_builder = chromium_swangle_linux_builder,
     chromium_swangle_mac_builder = chromium_swangle_mac_builder,
     chromium_swangle_windows_builder = chromium_swangle_windows_builder,
+    chromium_updater_mac_builder = chromium_updater_mac_builder,
+    chromium_updater_win_builder = chromium_updater_win_builder,
     chromium_win_builder = chromium_win_builder,
     gpu_chromium_android_builder = gpu_chromium_android_builder,
     gpu_chromium_linux_builder = gpu_chromium_linux_builder,

infra/config/subprojects/chromium/try.star

@@ -141,6 +141,10 @@ try_.list_view(
     name = "tryserver.chromium.swangle",
 )
 
+try_.list_view(
+    name = "tryserver.chromium.updater",
+)
+
 try_.list_view(
     name = "tryserver.chromium.win",
     branch_selector = branches.STANDARD_MILESTONE,
@@ -1392,6 +1396,26 @@ try_.chromium_mac_ios_builder(
     },
 )
 
+try_.chromium_updater_mac_builder(
+    name = "mac-updater-try-builder-rel",
+    main_list_view = "try",
+    tryjob = try_.job(
+        location_regexp = [
+            ".+/[+]/chrome/updater/.+",
+        ],
+    ),
+)
+
+try_.chromium_updater_win_builder(
+    name = "win-updater-try-builder-rel",
+    main_list_view = "try",
+    tryjob = try_.job(
+        location_regexp = [
+            ".+/[+]/chrome/updater/.+",
+        ],
+    ),
+)
+
 try_.chromium_win_builder(
     name = "win-annotator-rel",
 )

tools/mb/mb_config.pyl

@@ -1070,6 +1070,11 @@
       'win-swangle-try-x86': 'angle_deqp_release_trybot_x86',
     },
 
+    'tryserver.chromium.updater': {
+       'mac-updater-try-builder-rel': 'updater_release_trybot',
+       'win-updater-try-builder-rel': 'updater_release_trybot',
+    },
+
     'tryserver.chromium.win': {
       'gpu-fyi-try-win7-amd-dbg-32': 'gpu_fyi_tests_debug_trybot_x86',
       'gpu-fyi-try-win7-amd-dqp-32': 'angle_deqp_release_trybot_x86',
@@ -2305,6 +2310,10 @@
       'updater_on_win_mac', 'release',
     ],
 
+    'updater_release_trybot': [
+      'updater_on_win_mac', 'release_trybot',
+    ],
+
     'ozone_linux_release_bot': [
       'ozone_linux', 'release_bot',
     ],

tools/mb/mb_config_expectations/tryserver.chromium.updater.json

+{
+  "mac-updater-try-builder-rel": {
+    "gn_args": {
+      "dcheck_always_on": true,
+      "is_component_build": false,
+      "is_debug": false,
+      "is_google_branded": true,
+      "symbol_level": 1,
+      "use_goma": true
+    }
+  },
+  "win-updater-try-builder-rel": {
+    "gn_args": {
+      "dcheck_always_on": true,
+      "is_component_build": false,
+      "is_debug": false,
+      "is_google_branded": true,
+      "symbol_level": 1,
+      "use_goma": true
+    }
+  }
+}
\ No newline at end of file