Skip to content

GitLab

T
tangled
Commit 77a8b729 authored by Kyle Horimoto's avatar Kyle Horimoto Committed by Commit Bot
Browse files
Options

[CrOS Settings] Remove "EasyUnlock" search tags 

After discussions with jessejames@, we should not use internal code
names as search tags.

Bug: b/156109290
Change-Id: I67d2badcf1af5db66812d189d99a72ecb1ab6ae0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209611
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: default avatarRegan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#770369}
parent ae8b8f14
Hide whitespace changes
Inline Side-by-side
Showing with 4 additions and 14 deletions
chrome/app/os_settings_search_tag_strings.grdp
View file @ 77a8b729
......@@ -210,24 +210,18 @@
<message name="IDS_OS_SETTINGS_TAG_MULTIDEVICE_ALT3" desc="Text for search result item which, when clicked, navigates the user to multi-device settings (connects Android phone to Chromebook). Alternate phrase for: 'Connected devices settings', 'Better Together', 'Multi-device'">
Phone
</message>
<message name="IDS_OS_SETTINGS_TAG_MULTIDEVICE_SMART_LOCK" desc="Text for search result item which, when clicked, navigates the user to Smart Lock settings (unlock Chromebook with Android phone). Alternate phrase for: 'EasyUnlock'">
<message name="IDS_OS_SETTINGS_TAG_MULTIDEVICE_SMART_LOCK" desc="Text for search result item which, when clicked, navigates the user to Smart Lock settings (unlock Chromebook with Android phone).">
Smart Lock
</message>
<message name="IDS_OS_SETTINGS_TAG_MULTIDEVICE_SMART_LOCK_ALT1" desc="Text for search result item which, when clicked, navigates the user to Smart Lock settings (unlock Chromebook with Android phone). Alternate phrase for: 'Smart Lock settings'">
EasyUnlock
</message>
<message name="IDS_OS_SETTINGS_TAG_MULTIDEVICE_MESSAGES" desc="Text for search result item which, when clicked, navigates the user to Messages settings (sync SMS between Chromebook and Android phone). Alternate phrase for: 'Android messages'">
Messages settings
</message>
<message name="IDS_OS_SETTINGS_TAG_MULTIDEVICE_MESSAGES_ALT1" desc="Text for search result item which, when clicked, navigates the user to Messages settings (sync SMS between Chromebook and Android phone). Alternate phrase for: 'Messages settings'">
Android messages
</message>
<message name="IDS_OS_SETTINGS_TAG_MULTIDEVICE_SMART_LOCK_OPTIONS" desc="Text for search result item which, when clicked, navigates the user to Smart Lock screen lock settings (for signing into Chromebook with Android phone). Alternate phrase for: 'EasyUnlock screen lock'">
<message name="IDS_OS_SETTINGS_TAG_MULTIDEVICE_SMART_LOCK_OPTIONS" desc="Text for search result item which, when clicked, navigates the user to Smart Lock screen lock settings (for signing into Chromebook with Android phone).">
Smart Lock screen lock options
</message>
<message name="IDS_OS_SETTINGS_TAG_MULTIDEVICE_SMART_LOCK_OPTIONS_ALT1" desc="Text for search result item which, when clicked, navigates the user to Smart Lock screen lock settings (for signing into Chromebook with Android phone). Alternate phrase for: 'Smart Lock screen lock options'">
EasyUnlock screen lock
</message>
<message name="IDS_OS_SETTINGS_TAG_MULTIDEVICE_FORGET" desc="Text for search result item which, when clicked, navigates the user to multi-device settings, which an option to disconnect the currently-connected Android phone. Alternate phrase for: 'Disconnect connected phone'">
Forget connected phone
</message>
......
chrome/browser/ui/webui/settings/chromeos/multidevice_section.cc
View file @ 77a8b729
......@@ -51,9 +51,7 @@ const std::vector<SearchConcept>& GetMultiDeviceSearchConcepts() {
mojom::SearchResultIcon::kLock,
mojom::SearchResultDefaultRank::kMedium,
mojom::SearchResultType::kSubpage,
{.subpage = mojom::Subpage::kSmartLock},
{IDS_OS_SETTINGS_TAG_MULTIDEVICE_SMART_LOCK_ALT1,
SearchConcept::kAltTagEnd}},
{.subpage = mojom::Subpage::kSmartLock}},
});
return *tags;
}
......@@ -65,9 +63,7 @@ const std::vector<SearchConcept>& GetMultiDeviceOptedInSearchConcepts() {
mojom::SearchResultIcon::kLock,
mojom::SearchResultDefaultRank::kMedium,
mojom::SearchResultType::kSubpage,
{.subpage = mojom::Subpage::kSmartLock},
{IDS_OS_SETTINGS_TAG_MULTIDEVICE_SMART_LOCK_OPTIONS_ALT1,
SearchConcept::kAltTagEnd}},
{.subpage = mojom::Subpage::kSmartLock}},
{IDS_OS_SETTINGS_TAG_MULTIDEVICE_FORGET,
mojom::kMultiDeviceFeaturesSubpagePath,
mojom::SearchResultIcon::kPhone,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment