Commit 77f24899 authored by Anton Bikineev's avatar Anton Bikineev Committed by Commit Bot

heap: Change DCHECK in FromInnerAddress to CHECK

This change is needed to check canary for existing bugs caused by
incorrect algorithm of page header extraction for large pages.

To sherrifs: this causes regressions. The commit will be reverted in
a few days.

Change-Id: I0df59aa055b8783c834cfdf29717d388294fe9bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827364Reviewed-by: default avatarUlan Degenbaev <ulan@chromium.org>
Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Reviewed-by: default avatarAnton Bikineev <bikineev@chromium.org>
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700273}
parent 8118135c
...@@ -1069,7 +1069,7 @@ PLATFORM_EXPORT ALWAYS_INLINE BasePage* PageFromObject(const void* object) { ...@@ -1069,7 +1069,7 @@ PLATFORM_EXPORT ALWAYS_INLINE BasePage* PageFromObject(const void* object) {
BasePage* page = reinterpret_cast<BasePage*>(BlinkPageAddress(address) + BasePage* page = reinterpret_cast<BasePage*>(BlinkPageAddress(address) +
kBlinkGuardPageSize); kBlinkGuardPageSize);
// Page must have a valid magic. // Page must have a valid magic.
DCHECK(page->IsValid()); CHECK(page->IsValid());
#if DCHECK_IS_ON() #if DCHECK_IS_ON()
DCHECK(page->Contains(address)); DCHECK(page->Contains(address));
#endif #endif
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment