Commit 780e141a authored by Dylan Cutler's avatar Dylan Cutler Committed by Commit Bot

Actually record identifiable WebGL parameters that are integers.

The instrumentation of GetIntParameter() was accidentally omitted from
http://crrev.com/c/2364953.

I also replaced the uses of IdentifiableTokenBuilder.AddToken() to the
preferred method, AddValue(), where appropriate in the same file.

Bug: 973801
Change-Id: I433e10fec8ad727fa57dbfb8ce5546d9fd96ab6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438750Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Cr-Commit-Position: refs/heads/master@{#812098}
parent fbe2ef31
...@@ -7150,6 +7150,7 @@ ScriptValue WebGLRenderingContextBase::GetIntParameter( ...@@ -7150,6 +7150,7 @@ ScriptValue WebGLRenderingContextBase::GetIntParameter(
break; break;
} }
} }
RecordIdentifiableGLParameterDigest(pname, value);
return WebGLAny(script_state, value); return WebGLAny(script_state, value);
} }
...@@ -7195,7 +7196,7 @@ ScriptValue WebGLRenderingContextBase::GetWebGLFloatArrayParameter( ...@@ -7195,7 +7196,7 @@ ScriptValue WebGLRenderingContextBase::GetWebGLFloatArrayParameter(
ShouldMeasureGLParam(pname)) { ShouldMeasureGLParam(pname)) {
blink::IdentifiableTokenBuilder builder; blink::IdentifiableTokenBuilder builder;
for (unsigned i = 0; i < length; i++) { for (unsigned i = 0; i < length; i++) {
builder.AddToken(value[i]); builder.AddValue(value[i]);
} }
RecordIdentifiableGLParameterDigest(pname, builder.GetToken()); RecordIdentifiableGLParameterDigest(pname, builder.GetToken());
} }
...@@ -7224,7 +7225,7 @@ ScriptValue WebGLRenderingContextBase::GetWebGLIntArrayParameter( ...@@ -7224,7 +7225,7 @@ ScriptValue WebGLRenderingContextBase::GetWebGLIntArrayParameter(
ShouldMeasureGLParam(pname)) { ShouldMeasureGLParam(pname)) {
blink::IdentifiableTokenBuilder builder; blink::IdentifiableTokenBuilder builder;
for (unsigned i = 0; i < length; i++) { for (unsigned i = 0; i < length; i++) {
builder.AddToken(value[i]); builder.AddValue(value[i]);
} }
RecordIdentifiableGLParameterDigest(pname, builder.GetToken()); RecordIdentifiableGLParameterDigest(pname, builder.GetToken());
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment