Fixing ProtectedMembersInFinalClass errorprone warnings

The existing errors are using protected visibility when they could be
using package-private visibility.

Bug: 1029038
Change-Id: Iec1da0fed876d2d2abc68414bdb7175aab02db95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602890Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Auto-Submit: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841085}

build/android/gyp/compile_java.py

@@ -47,7 +47,6 @@ ERRORPRONE_WARNINGS_TO_DISABLE = [
     'MutablePublicArray',
     'UnescapedEntity',
     'NonCanonicalType',
-    'ProtectedMembersInFinalClass',
     'AlmostJavadoc',
     # TODO(crbug.com/834807): Follow steps in bug
     'DoubleBraceInitialization',

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/suggestions/TabSuggestionsClientFetcher.java

@@ -45,7 +45,7 @@ public final class TabSuggestionsClientFetcher implements TabSuggestionsFetcher
         }
     }
 
-    protected void setUseBaselineTabSuggestionsForTesting() {
+    void setUseBaselineTabSuggestionsForTesting() {
         mClientSuggestionProviders =
                 new ArrayList<>(Arrays.asList(new BaselineTabSuggestionProvider()));
     }

chrome/android/java/src/org/chromium/chrome/browser/background_sync/GooglePlayServicesChecker.java

@@ -27,7 +27,7 @@ final class GooglePlayServicesChecker {
      */
     @CalledByNative
     @VisibleForTesting
-    protected static boolean shouldDisableBackgroundSync() {
+    static boolean shouldDisableBackgroundSync() {
         boolean isAvailable = true;
         if (!ExternalAuthUtils.getInstance().canUseGooglePlayServices()) {
             Log.i(TAG, "Disabling Background Sync because Play Services is not up to date.");

chrome/browser/tab/java/src/org/chromium/chrome/browser/tab/state/PersistedTabDataConfiguration.java

@@ -131,7 +131,7 @@ public enum PersistedTabDataConfiguration {
     }
 
     @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE)
-    protected static PersistedTabDataConfiguration getTestConfig() {
+    static PersistedTabDataConfiguration getTestConfig() {
         return TEST_CONFIG;
     }
 }

chromecast/base/java/src/org/chromium/chromecast/base/CastSettingsManager.java

@@ -40,9 +40,9 @@ public final class CastSettingsManager {
     private final ContentResolver mContentResolver;
 
     @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE)
-    protected ContentObserver mDeviceNameObserver;
+    ContentObserver mDeviceNameObserver;
     @VisibleForTesting(otherwise = VisibleForTesting.PRIVATE)
-    protected ContentObserver mIsDeviceProvisionedObserver;
+    ContentObserver mIsDeviceProvisionedObserver;
 
     /**
      * Can be implemented to receive notifications from a CastSettingsManager instance when