Commit 7849177e authored by Etienne Pierre-doray's avatar Etienne Pierre-doray Committed by Chromium LUCI CQ

[Jobs API]: Clean up deprecate functions in gin.

This CL removes Jobs deprecated function overrides in gin:
IsRunning()
IsCompleted()

Change-Id: Ib7b39c4004bf2429e4e4a585062a8fbabfe54c16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638334Reviewed-by: default avatarRoss McIlroy <rmcilroy@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845246}
parent 1fc7d07f
...@@ -325,10 +325,6 @@ class JobHandleImpl : public v8::JobHandle { ...@@ -325,10 +325,6 @@ class JobHandleImpl : public v8::JobHandle {
bool IsActive() override { return handle_.IsActive(); } bool IsActive() override { return handle_.IsActive(); }
bool IsValid() override { return !!handle_; } bool IsValid() override { return !!handle_; }
// TODO(etiennep): Cleanup once rename is complete.
bool IsCompleted() override { return !IsActive(); }
bool IsRunning() override { return IsValid(); }
private: private:
static base::TaskPriority ToBaseTaskPriority(v8::TaskPriority priority) { static base::TaskPriority ToBaseTaskPriority(v8::TaskPriority priority) {
switch (priority) { switch (priority) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment