Handle some cases download is running without full browser

When browser is not fully running, Profile cannot be accessed.
This CL also disables the use of toast as it is very expensive when
full browser is not running.

BUG=695115

Change-Id: I7560e3684307741e0a1ba01ec8efec0ff97fdbc4
Reviewed-on: https://chromium-review.googlesource.com/1165849Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581358}

chrome/android/java/src/org/chromium/chrome/browser/download/DownloadController.java

@@ -17,11 +17,13 @@ import org.chromium.base.ApplicationStatus;
 import org.chromium.base.Callback;
 import org.chromium.base.ContextUtils;
 import org.chromium.base.annotations.CalledByNative;
+import org.chromium.base.library_loader.LibraryProcessType;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.ChromeActivity;
 import org.chromium.chrome.browser.tab.Tab;
 import org.chromium.chrome.browser.tabmodel.TabModelSelector;
 import org.chromium.chrome.browser.util.FeatureUtilities;
+import org.chromium.content_public.browser.BrowserStartupController;
 import org.chromium.content_public.browser.WebContents;
 import org.chromium.ui.base.AndroidPermissionDelegate;
 import org.chromium.ui.base.PermissionCallback;
@@ -252,6 +254,10 @@ public class DownloadController {
      */
     @CalledByNative
     private static void onDownloadStarted() {
+        if (!BrowserStartupController.get(LibraryProcessType.PROCESS_BROWSER)
+                        .isStartupSuccessfullyCompleted()) {
+            return;
+        }
         if (FeatureUtilities.isDownloadProgressInfoBarEnabled()) return;
         DownloadUtils.showDownloadStartToast(ContextUtils.getApplicationContext());
     }

chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java

@@ -1113,7 +1113,9 @@ public class DownloadManagerService
      */
     private long getNativeDownloadManagerService() {
         if (mNativeDownloadManagerService == 0) {
-            mNativeDownloadManagerService = nativeInit();
+            mNativeDownloadManagerService =
+                    nativeInit(BrowserStartupController.get(LibraryProcessType.PROCESS_BROWSER)
+                                       .isStartupSuccessfullyCompleted());
         }
         return mNativeDownloadManagerService;
     }
@@ -1887,7 +1889,7 @@ public class DownloadManagerService
     private static native boolean nativeIsSupportedMimeType(String mimeType);
     private static native int nativeGetAutoResumptionLimit();
 
-    private native long nativeInit();
+    private native long nativeInit(boolean isFullBrowserStarted);
     private native void nativeOpenDownload(long nativeDownloadManagerService, String downloadGuid,
             boolean isOffTheRecord, int source);
     private native void nativeResumeDownload(

chrome/browser/android/download/download_manager_service.cc

@@ -140,17 +140,13 @@ ScopedJavaLocalRef<jobject> DownloadManagerService::CreateJavaDownloadInfo(
       item->GetLastAccessTime().ToJavaTime(), item->IsDangerous());
 }
 
-static jlong JNI_DownloadManagerService_Init(
-    JNIEnv* env,
-    const JavaParamRef<jobject>& jobj) {
-  Profile* profile = ProfileManager::GetActiveUserProfile();
+static jlong JNI_DownloadManagerService_Init(JNIEnv* env,
+                                             const JavaParamRef<jobject>& jobj,
+                                             jboolean is_full_browser_started) {
   DownloadManagerService* service = DownloadManagerService::GetInstance();
   service->Init(env, jobj);
-  DownloadCoreService* download_core_service =
-      DownloadCoreServiceFactory::GetForBrowserContext(profile);
-  DownloadHistory* history = download_core_service->GetDownloadHistory();
-  if (history)
-    history->AddObserver(service);
+  if (is_full_browser_started)
+    service->OnFullBrowserStarted(env, jobj);
   return reinterpret_cast<intptr_t>(service);
 }
 
@@ -175,9 +171,18 @@ void DownloadManagerService::NotifyServiceStarted(
 void DownloadManagerService::Init(
     JNIEnv* env,
     jobject obj) {
+  java_ref_.Reset(env, obj);
+}
+
+void DownloadManagerService::OnFullBrowserStarted(JNIEnv* env, jobject obj) {
   registrar_.Add(this, chrome::NOTIFICATION_PROFILE_CREATED,
                  content::NotificationService::AllSources());
-  java_ref_.Reset(env, obj);
+  Profile* profile = ProfileManager::GetActiveUserProfile();
+  DownloadCoreService* download_core_service =
+      DownloadCoreServiceFactory::GetForBrowserContext(profile);
+  DownloadHistory* history = download_core_service->GetDownloadHistory();
+  if (history)
+    history->AddObserver(this);
 }
 
 void DownloadManagerService::Observe(

chrome/browser/android/download/download_manager_service.h

@@ -58,6 +58,9 @@ class DownloadManagerService
   // Called to Initialize this object.
   void Init(JNIEnv* env, jobject obj);
 
+  // Called when full browser process starts.
+  void OnFullBrowserStarted(JNIEnv* env, jobject obj);
+
   // Called to open a given download item.
   void OpenDownload(download::DownloadItem* download, int source);