Commit 78539dfc authored by timurrrr@chromium.org's avatar timurrrr@chromium.org

Make content_shell.exe a console app in ASan/Win builds

This will help ASan reports appear on stderr when content_shell is run from CMD.exe console or on ClusterFuzz

See also http://crrev.com/275067 where the same was applied to chrome.exe

BUG=345874

Review URL: https://codereview.chromium.org/394853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283551 0039d316-1c4b-4281-b951-d872f2087c98
parent 34621d16
......@@ -519,9 +519,6 @@
'INFOPLIST_FILE': 'shell/app/app-Info.plist',
},
'msvs_settings': {
'VCLinkerTool': {
'SubSystem': '2', # Set /SUBSYSTEM:WINDOWS
},
'VCManifestTool': {
'AdditionalManifestFiles': [
'shell/app/shell.exe.manifest',
......@@ -553,6 +550,13 @@
'../sandbox/sandbox.gyp:sandbox',
],
}], # OS=="win"
['OS=="win" and asan==0', {
'msvs_settings': {
'VCLinkerTool': {
'SubSystem': '2', # Set /SUBSYSTEM:WINDOWS
},
},
}], # OS=="win" and asan==0
['OS=="mac"', {
'product_name': '<(content_shell_product_name)',
'dependencies!': [
......
......@@ -16,7 +16,14 @@
#if defined(OS_WIN)
#if !defined(ADDRESS_SANITIZER)
int APIENTRY wWinMain(HINSTANCE instance, HINSTANCE, wchar_t*, int) {
#else
// The AddressSanitizer build should be a console program as it prints out stuff
// on stderr.
int main() {
HINSTANCE instance = GetModuleHandle(NULL);
#endif
sandbox::SandboxInterfaceInfo sandbox_info = {0};
content::InitializeSandboxInfo(&sandbox_info);
content::ShellMainDelegate delegate;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment