Commit 788154c9 authored by Fergal Daly's avatar Fergal Daly Committed by Commit Bot

arthur's comments

Change-Id: I9e31d6465e4f4cd710611ffea990ded46ee6bb1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154625Reviewed-by: default avatarArthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#762730}
parent 95fc3205
...@@ -2,12 +2,16 @@ ...@@ -2,12 +2,16 @@
## TL;DR ## TL;DR
RenderDocument stops us reusing RenderFrames and RenderFrameHosts, Chrome currently switches to a new RenderFrameHost
simplifying decisions, when loading a new document
eliminating logic for reuse if the render process is different to the previous one.
and making RenderFrameHost a browser-side object The RenderDocument project is about making the switch to happen unconditionally.
that corresponds to the renderer-side document This:
(hence RenderDocument).
* Eliminates the logic for navigating inside the same RenderFrameHost
* Makes RenderFrameHost in the browser process 1:1 with the Document.
* Prevents security bugs,
e.g. reusing the data/capabilities from the wrong document.
## Details ## Details
...@@ -30,24 +34,22 @@ for crashed frames. ...@@ -30,24 +34,22 @@ for crashed frames.
https://crbug.com/936696 https://crbug.com/936696
[design doc](https://docs.google.com/document/d/1C2VKkFRSc0kdmqjKan1G4NlNlxWZqE4Wam41FNMgnmA)
[high-level view of the work needed](https://docs.google.com/document/d/1UzVOmTj2IJ0ecz7CZicTK6ow2rr9wgLTGfY5hjyLmT4) [high-level view of the work needed](https://docs.google.com/document/d/1UzVOmTj2IJ0ecz7CZicTK6ow2rr9wgLTGfY5hjyLmT4)
[discussion of how we can land it safely](https://docs.google.com/document/d/1ZHWWEYT1L5Zgh2lpC7DHXXZjKcptI877KKOqjqxE2Ns) [discussion of how we can land it safely](https://docs.google.com/document/d/1ZHWWEYT1L5Zgh2lpC7DHXXZjKcptI877KKOqjqxE2Ns)
# Stages # Stages
We have 3 stages that are behind flags We have 3 stages that are behind flags.
1. crashed-frames: 1. crashed-frames:
With this enabled we get a new RenderFrameHost when reloading a crashed frame. A new RenderFrameHost is used for reloading a crashed document.
2. subframes: 2. subframes:
With this enabled, A new RenderFrameHost is used for every nested document.
when a subframe navigates
we get a new RenderFrame and RenderFrameHost.
3. main frames: 3. main frames:
With this enabled, A new RenderFrameHost is used for every document.
when the main frame navigates
we get a new RenderFrame and RenderFrameHost.
# Test changes # Test changes
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment