Fix timeout on RTCRtpTransceiver test.

This CL should make the test run consistently and always finish; we break
out early from the test that was failing rather than waiting forever.

Bug: chromium:869126
Change-Id: Ic52fbf0dea69a03645165a073354f61a3d28ad81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250065
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779810}

third_party/blink/web_tests/TestExpectations

@@ -2971,7 +2971,6 @@ crbug.com/626703 [ Mac10.13 ] external/wpt/preload/download-resources.html [ Fai
 crbug.com/626703 [ Retina ] external/wpt/preload/download-resources.html [ Failure Timeout ]
 crbug.com/626703 [ Mac10.10 ] external/wpt/preload/download-resources.html [ Failure Timeout ]
 crbug.com/626703 external/wpt/css/css-writing-modes/text-combine-upright-digits-001-manual.html [ Skip ]
-crbug.com/626703 external/wpt/webrtc/RTCRtpTransceiver.https.html [ Crash Timeout ]
 crbug.com/626703 external/wpt/css/css-writing-modes/text-combine-upright-all-001-manual.html [ Skip ]
 crbug.com/626703 external/wpt/css/css-writing-modes/text-combine-upright-digits-002-manual.html [ Skip ]
 crbug.com/626703 external/wpt/css/css-writing-modes/text-combine-upright-all-002-manual.html [ Skip ]
@@ -3170,7 +3169,6 @@ crbug.com/367760 external/wpt/svg/pservers/reftests/meshgradient-basic-001.svg [
 virtual/webrtc-wpt-plan-b/external/wpt/webrtc/RTCPeerConnection-iceGatheringState.html [ Pass ]
 virtual/webrtc-wpt-plan-b/external/wpt/webrtc/RTCPeerConnection-operations.https.html [ Pass ]
 virtual/webrtc-wpt-plan-b/external/wpt/webrtc/RTCPeerConnection-restartIce-onnegotiationneeded.https.html [ Pass ]
-virtual/webrtc-wpt-plan-b/external/wpt/webrtc/RTCRtpTransceiver.https.html [ Pass ]
 
 # See also crbug.com/920100 (sheriff 2019-01-09).
 crbug.com/626703 external/wpt/referrer-policy/css-integration/svg/external-stylesheet.html [ Timeout Failure ]

third_party/blink/web_tests/external/wpt/webrtc/RTCRtpTransceiver.https-expected.txt

 This is a testharness.js-based test.
-FAIL RTCRtpTransceiver Uncaught ReferenceError: checkAddIceCandidateToStoppedTransceiver is not defined
+PASS checkAddTransceiverNoTrack
+PASS checkAddTransceiverWithTrack
+PASS checkAddTransceiverWithAddTrack
+PASS checkAddTransceiverWithDirection
+FAIL checkMsidNoTrackId promise_test: Unhandled rejection with value: object "OperationError: Failed to execute 'setRemoteDescription' on 'RTCPeerConnection': Failed to parse SessionDescription. a=msid:fake-stream-id Expects 2 fields."
+PASS checkAddTransceiverWithSetRemoteOfferSending
+PASS checkAddTransceiverWithSetRemoteOfferNoSend
+PASS checkAddTransceiverBadKind
+PASS checkNoMidOffer
+PASS checkNoMidAnswer
+PASS checkSetDirection
+PASS checkCurrentDirection
+PASS checkSendrecvWithNoSendTrack
+PASS checkSendrecvWithTracklessStream
+PASS checkAddTransceiverNoTrackDoesntPair
+PASS checkAddTransceiverWithTrackDoesntPair
+PASS checkAddTransceiverThenReplaceTrackDoesntPair
+FAIL checkAddTransceiverThenAddTrackPairs assert_equals: expected "[{sender:{track:{}}}]" but got "[{sender:{track:{}}},{}]"
+PASS checkAddTrackPairs
+PASS checkReplaceTrackNullDoesntPreventPairing
+PASS checkRemoveAndReadd
+PASS checkAddTrackExistingTransceiverThenRemove
+FAIL checkRemoveTrackNegotiation assert_equals: pc2.setRemoteDescription(offer) should've added 2 tracks to receive stream expected 2 but got 0
+FAIL checkMute assert_true: expected true got false
+FAIL checkStop promise_test: Unhandled rejection with value: object "TypeError: stoppedTransceiver.stop is not a function"
+FAIL checkStopAfterCreateOffer promise_test: Unhandled rejection with value: object "TypeError: pc1.getTransceivers(...)[0].stop is not a function"
+FAIL checkStopAfterSetLocalOffer promise_test: Unhandled rejection with value: object "TypeError: pc1.getTransceivers(...)[0].stop is not a function"
+FAIL checkStopAfterSetRemoteOffer promise_test: Unhandled rejection with value: object "TypeError: pc2.getTransceivers(...)[0].stop is not a function"
+FAIL checkStopAfterCreateAnswer promise_test: Unhandled rejection with value: object "TypeError: pc2.getTransceivers(...)[0].stop is not a function"
+FAIL checkStopAfterSetLocalAnswer promise_test: Unhandled rejection with value: object "TypeError: pc2.getTransceivers(...)[0].stop is not a function"
+FAIL checkStopAfterClose assert_equals: Stopping a transceiver on a closed PC should throw. throws InvalidStateError expected "InvalidStateError" but got "TypeError"
+FAIL checkLocalRollback promise_test: Unhandled rejection with value: object "TypeError: pc.getTransceivers(...)[0].stop is not a function"
+PASS checkRollbackAndSetRemoteOfferWithDifferentType
+FAIL checkRemoteRollback assert_equals: expected "{currentDirection:null,mid:null,stopped:true}" but got "{currentDirection:null,mid:null,stopped:false}"
+FAIL checkMsectionReuse promise_test: Unhandled rejection with value: object "TypeError: pc2.getTransceivers(...)[0].stop is not a function"
+FAIL checkStopAfterCreateOfferWithReusedMsection promise_test: Unhandled rejection with value: object "TypeError: pc1.getTransceivers(...)[1].stop is not a function"
+FAIL checkAddIceCandidateToStoppedTransceiver promise_test: Unhandled rejection with value: object "TypeError: pc1.getTransceivers(...)[1].stop is not a function"
+FAIL checkBundleTagRejected promise_test: Unhandled rejection with value: object "TypeError: pc2.getTransceivers(...)[0].stop is not a function"
 Harness: the test ran to completion.
 

third_party/blink/web_tests/external/wpt/webrtc/RTCRtpTransceiver.https.html

@@ -400,8 +400,9 @@
     const offer = await pc1.createOffer();
     await pc1.setLocalDescription(offer);
     // Remove track-id from msid
-    offer.sdp = offer.sdp.replace(/(a=msid:[^ \t]+).*\r\n/g, "$1\r\n");
-    assert_true(offer.sdp.includes(`a=msid:${stream.id}\r\n`));
+    // Fixate stream-id so that error message is consistent.
+    offer.sdp = offer.sdp.replace(/(a=msid:[^ \t]+).*\r\n/g,
+                                  "a=msid:fake-stream-id\r\n");
     await pc2.setRemoteDescription(offer);
     const answer = await pc2.createAnswer();
     await pc1.setRemoteDescription(answer);
@@ -1146,10 +1147,16 @@
 
     let gotUnmuteAudio2 = gotUnmuteEvent(pc2.getTransceivers()[0].receiver.track);
     let gotUnmuteVideo2 = gotUnmuteEvent(pc2.getTransceivers()[1].receiver.track);
+    // Jump out before waiting if a track is unmuted before RTP starts flowing.
+    assert_true(pc1.getTransceivers()[0].receiver.track.muted);
+    assert_true(pc1.getTransceivers()[1].receiver.track.muted);
+    assert_true(pc2.getTransceivers()[0].receiver.track.muted);
+    assert_true(pc2.getTransceivers()[1].receiver.track.muted);
 
     await iceConnected(pc1);
     await iceConnected(pc2);
 
+
     // Check that receive tracks are unmuted when RTP starts flowing
     await gotUnmuteAudio1;
     await gotUnmuteVideo1;

third_party/blink/web_tests/virtual/webrtc-wpt-plan-b/external/wpt/webrtc/RTCRtpTransceiver.https-expected.txt

@@ -4,7 +4,7 @@ FAIL checkAddTransceiverNoTrack promise_test: Unhandled rejection with value: ob
 FAIL checkAddTransceiverWithTrack promise_test: Unhandled rejection with value: object "InvalidStateError: Failed to execute 'addTransceiver' on 'RTCPeerConnection': This operation is only supported in 'unified-plan'."
 FAIL checkAddTransceiverWithAddTrack assert_equals: expected "[{currentDirection:null,direction:\"sendrecv\",mid:null,receiver:{track:{kind:\"audio\"}},sender:{track:{}},stopped:false},{currentDirection:null,direction:\"sendrecv\",mid:null,receiver:{track:{kind:\"video\"}},sender:{track:{}},stopped:false}]" but got "[]"
 FAIL checkAddTransceiverWithDirection promise_test: Unhandled rejection with value: object "InvalidStateError: Failed to execute 'addTransceiver' on 'RTCPeerConnection': This operation is only supported in 'unified-plan'."
-FAIL checkMsidNoTrackId assert_true: expected true got false
+PASS checkMsidNoTrackId
 FAIL checkAddTransceiverWithSetRemoteOfferSending promise_test: Unhandled rejection with value: object "InvalidStateError: Failed to execute 'addTransceiver' on 'RTCPeerConnection': This operation is only supported in 'unified-plan'."
 FAIL checkAddTransceiverWithSetRemoteOfferNoSend promise_test: Unhandled rejection with value: object "InvalidStateError: Failed to execute 'addTransceiver' on 'RTCPeerConnection': This operation is only supported in 'unified-plan'."
 FAIL checkAddTransceiverBadKind assert_true: addTransceiver("foo") throws a TypeError expected true got false