Commit 78cf96a7 authored by Lei Zhang's avatar Lei Zhang Committed by Commit Bot

Remove thestig's ownership and TODOs in components/autofill/ios.

I have not worked on Autofill in years, so I am giving up my ownership
here. A bug has been filed for a TODO with my name on it.

Bug: 1030490
Change-Id: I9afb96a4a8b4a7eefc97854e2c5f29746eb5b129
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949208Reviewed-by: default avatarMoe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721629}
parent 1e0899e5
...@@ -274,7 +274,6 @@ base::string16 FindChildTextInner(const WebNode& node, ...@@ -274,7 +274,6 @@ base::string16 FindChildTextInner(const WebNode& node,
} }
// Same as FindChildText() below, but with a list of div nodes to skip. // Same as FindChildText() below, but with a list of div nodes to skip.
// TODO(thestig): See if other FindChildText() callers can benefit from this.
base::string16 FindChildTextWithIgnoreList( base::string16 FindChildTextWithIgnoreList(
const WebNode& node, const WebNode& node,
const std::set<WebNode>& divs_to_skip) { const std::set<WebNode>& divs_to_skip) {
......
mahmadi@chromium.org mahmadi@chromium.org
thestig@chromium.org
...@@ -526,8 +526,7 @@ __gCrWeb.fill.getCanonicalActionForForm = function(formElement) { ...@@ -526,8 +526,7 @@ __gCrWeb.fill.getCanonicalActionForForm = function(formElement) {
* std::map<WebFormControlElement, FormFieldData*>* element_map) * std::map<WebFormControlElement, FormFieldData*>* element_map)
* in chromium/src/components/autofill/content/renderer/form_autofill_util.cc * in chromium/src/components/autofill/content/renderer/form_autofill_util.cc
* *
* TODO(thestig): Make |element_map| a Map when Chrome makes iOS 8 and Safari 8 * TODO(crbug.com/1030490): Make |elementArray| a Map.
* part of the minimal requirements.
* *
* @param {Array<FormControlElement>} controlElements The control elements that * @param {Array<FormControlElement>} controlElements The control elements that
* will be processed. * will be processed.
...@@ -608,6 +607,7 @@ function isVisibleNode_(node) { ...@@ -608,6 +607,7 @@ function isVisibleNode_(node) {
* *
* This also uses (|controlElements|, |elementArray|) because there is no * This also uses (|controlElements|, |elementArray|) because there is no
* guaranteeded Map support on iOS yet. * guaranteeded Map support on iOS yet.
* TODO(crbug.com/1030490): Make |elementArray| a Map.
* *
* @param {NodeList} labels The labels to match. * @param {NodeList} labels The labels to match.
* @param {HTMLFormElement} formElement The form element being processed. * @param {HTMLFormElement} formElement The form element being processed.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment