Commit 78d579a3 authored by Mike Dougherty's avatar Mike Dougherty Committed by Commit Bot

Re-enable context menu tests

Bug: 989550
Change-Id: Ib20196500921be1d0c5adc305e5a5eca56132991
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804214Reviewed-by: default avatarKurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: default avatarEric Noyau <noyau@chromium.org>
Commit-Queue: Eric Noyau <noyau@chromium.org>
Auto-Submit: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697270}
parent 1597b857
......@@ -162,13 +162,6 @@ void SelectTabAtIndexInCurrentMode(NSUInteger index) {
@implementation ContextMenuTestCase
// TODO(crbug.com/989550) Disable broken context menu tests on Xcode 11 beta 5.
+ (NSArray*)testInvocations {
if (@available(iOS 13, *))
return @[];
return [super testInvocations];
}
+ (void)setUp {
[super setUp];
[ChromeEarlGrey setContentSettings:CONTENT_SETTING_ALLOW];
......@@ -263,9 +256,10 @@ void SelectTabAtIndexInCurrentMode(NSUInteger index) {
CGRectGetMidX([chrome_test_util::GetActiveViewController() view].bounds),
topInset + 20.0);
// Duration should match |kContextMenuLongPressDuration| as defined in
// web_view_actions.mm.
[[EarlGrey selectElementWithMatcher:WebViewMatcher()]
performAction:grey_longPressAtPointWithDuration(
point, kGREYLongPressDefaultDuration)];
performAction:grey_longPressAtPointWithDuration(point, 1.0)];
TapOnContextMenuButton(OpenImageInNewTabButton());
[ChromeEarlGrey waitForMainTabCount:2];
......
......@@ -575,11 +575,6 @@ void TapSuppressDialogsButton() {
// Tests that an alert is presented after a new tab animation is finished.
- (void)testShowJavaScriptAfterNewTabAnimation {
// TODO(crbug.com/989550) Disable broken context menu tests on Xc11b5.
if (@available(iOS 13, *)) {
EARL_GREY_TEST_DISABLED(@"Test disabled on iOS13.");
}
// Load the test page with a link to kOnLoadAlertURL and long tap on the link.
[self loadPageWithLink];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment