[omnibox] Launch On Device Head Suggest Incognito for all clients.

Bug: 925072
Change-Id: Ib86cd7d6f99a8489e81f679f9f10265d02574a1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525962Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Ce Chen <cch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#825612}

components/omnibox/browser/on_device_head_provider_unittest.cc

@@ -121,34 +121,8 @@ TEST_F(OnDeviceHeadProviderTest, TestIfIncognitoIsAllowed) {
   EXPECT_CALL(*client_.get(), SearchSuggestEnabled())
       .WillRepeatedly(Return(true));
 
-  // By default incognito request will be accepted on mobile, rejected on
-  // desktop.
+  // By default incognito request will be accepted.
   {
-    base::test::ScopedFeatureList scoped_feature_list;
-    scoped_feature_list.InitAndEnableFeature(
-        omnibox::kOnDeviceHeadProviderNonIncognito);
-#if defined(OS_ANDROID) || defined(OS_IOS)
-    ASSERT_TRUE(IsOnDeviceHeadProviderAllowed(input));
-#else
-    ASSERT_FALSE(IsOnDeviceHeadProviderAllowed(input));
-#endif
-  }
-
-  // Now enable for incognito.
-  {
-    base::test::ScopedFeatureList scoped_feature_list;
-    scoped_feature_list.InitAndEnableFeature(
-        omnibox::kOnDeviceHeadProviderIncognito);
-    ASSERT_TRUE(IsOnDeviceHeadProviderAllowed(input));
-  }
-
-  // Test enable for both.
-  {
-    base::test::ScopedFeatureList scoped_feature_list;
-    scoped_feature_list.InitWithFeatures(
-        {omnibox::kOnDeviceHeadProviderNonIncognito,
-         omnibox::kOnDeviceHeadProviderIncognito},
-        {});
     ASSERT_TRUE(IsOnDeviceHeadProviderAllowed(input));
   }
 

components/omnibox/common/omnibox_features.cc

@@ -251,7 +251,7 @@ const base::Feature kReactiveZeroSuggestionsOnNTPRealbox{
 // NonIncognito will only controls behaviors under incognito / non-incognito
 // mode respectively.
 const base::Feature kOnDeviceHeadProviderIncognito{
-    "OmniboxOnDeviceHeadProviderIncognito", enabled_by_default_android_ios};
+    "OmniboxOnDeviceHeadProviderIncognito", base::FEATURE_ENABLED_BY_DEFAULT};
 const base::Feature kOnDeviceHeadProviderNonIncognito{
     "OmniboxOnDeviceHeadProviderNonIncognito", enabled_by_default_android_ios};