Commit 78f39310 authored by Xianzhu Wang's avatar Xianzhu Wang Committed by Commit Bot

Add comments about the reason of keeping the LayoutNG runtime flag

Change-Id: I2fb6037a3bed30a8d1d43c3f997471c695461e4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053616Reviewed-by: default avatarKoji Ishii <kojii@chromium.org>
Reviewed-by: default avatarIan Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741088}
parent 7b178e6d
...@@ -897,6 +897,11 @@ ...@@ -897,6 +897,11 @@
status: "experimental", status: "experimental",
}, },
{ {
// LayoutNG has been enabled in M76, but we still keep this flag for
// testing. See web_tests/FlagExpectations/disable-layout-ng for more
// details about running web tests with LayoutNG disabled. This flag also
// provides a convenient way for testing legacy layout code path in blink
// unit tests.
name: "LayoutNG", name: "LayoutNG",
implied_by: ["LayoutNGBlockFragmentation", "LayoutNGFieldset", "LayoutNGFlexBox", "LayoutNGFragmentItem", "LayoutNGLineCache", "EditingNG", "BidiCaretAffinity", "LayoutNGTable", "LayoutNGFragmentTraversal"], implied_by: ["LayoutNGBlockFragmentation", "LayoutNGFieldset", "LayoutNGFlexBox", "LayoutNGFragmentItem", "LayoutNGLineCache", "EditingNG", "BidiCaretAffinity", "LayoutNGTable", "LayoutNGFragmentTraversal"],
status: "stable", status: "stable",
......
...@@ -3,6 +3,14 @@ ...@@ -3,6 +3,14 @@
# tags: [ Release Debug ] # tags: [ Release Debug ]
# results: [ Timeout Crash Pass Failure Slow Skip ] # results: [ Timeout Crash Pass Failure Slow Skip ]
# These expectations are used when LayoutNG is disabled. We test this
# configuration on trybot linux_layout_tests_layout_ng_disabled.
# Though LayoutNG has been enabled in M76, we still keep running web tests with
# LayoutNG disabled because we still use legacy layout for editing, multicol,
# etc. Though we have tests for editing and multicol, the tests don't fully
# cover all layout code paths, so we need to run all web tests to ensure legacy
# layout still fully works.
# Tests that fail in legacy but pass in NG # Tests that fail in legacy but pass in NG
# accessibility/ # accessibility/
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment