Skip to content

GitLab

T
tangled
Commit 7956769c authored by Lucas Radaelli's avatar Lucas Radaelli Committed by Commit Bot
Browse files
Options

[fuchsia] Add a11y test that loads pages with out of process iframes 

Test for a previously submitted fix for handling pages with out of
process iframes.

Bug: 1136541, fuchsia:63092
Change-Id: Id79d1794c555b7710304fd2ffb751fd99ae60e87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547436Reviewed-by: default avatarSergey Ulanov <sergeyu@chromium.org>
Reviewed-by: default avatarSharon Yang <yangsharon@chromium.org>
Commit-Queue: Lucas Radaelli <lucasradaelli@google.com>
Cr-Commit-Position: refs/heads/master@{#829312}
parent e94ec7f8
Expand all Hide whitespace changes
Inline Side-by-side
Showing with 125 additions and 36 deletions
fuchsia/engine/browser/accessibility_bridge.cc
View file @ 7956769c
...@@ -93,9 +93,7 @@ void AccessibilityBridge::AccessibilityEventReceived( ...@@ -93,9 +93,7 @@ void AccessibilityBridge::AccessibilityEventReceived(
// Updates to AXTree must be applied first. // Updates to AXTree must be applied first.
for (const ui::AXTreeUpdate& update : details.updates) { for (const ui::AXTreeUpdate& update : details.updates) {
if (!update.has_tree_data && if (web_contents_->GetMainFrame()->GetAXTreeID() != details.ax_tree_id) {
ax_tree_.GetAXTreeID() != ui::AXTreeIDUnknown() &&
ax_tree_.GetAXTreeID() != details.ax_tree_id) {
// TODO(https://crbug.com/1128954): Add support for combining AXTrees. // TODO(https://crbug.com/1128954): Add support for combining AXTrees.
continue; continue;
} }
......
fuchsia/engine/test/data/iframe.html 0 → 100644
View file @ 7956769c
<html>
<head>
<title>this page has an iframe</title>
</head>
<body>
<iframe id="iframeId" name="iframeName" title="iframe title"></iframe>
<script>
var iframe = document.getElementById("iframeId");
iframe.src = iframeSrc;
iframe.onload = () => {
document.title = "iframe loaded";
}
</script>
</body>
</html>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment