Commit 79676e94 authored by bryner@chromium.org's avatar bryner@chromium.org

Remove some unused code in PhishingDOMFeatureExtractor.

BUG=none
TEST=PhishingDOMFeatureExtractorTest


Review URL: http://codereview.chromium.org/8384023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108028 0039d316-1c4b-4281-b951-d872f2087c98
parent 56986f93
...@@ -170,11 +170,7 @@ void PhishingDOMFeatureExtractor::ExtractFeaturesWithTimeout() { ...@@ -170,11 +170,7 @@ void PhishingDOMFeatureExtractor::ExtractFeaturesWithTimeout() {
} else { } else {
// We just moved to a new frame, so update our frame state // We just moved to a new frame, so update our frame state
// and advance to the first element. // and advance to the first element.
if (!ResetFrameData()) { ResetFrameData();
// Nothing in this frame, move on to the next one.
DLOG(WARNING) << "No content in frame, skipping";
continue;
}
cur_node = cur_frame_data_->elements.firstItem(); cur_node = cur_frame_data_->elements.firstItem();
} }
...@@ -381,7 +377,7 @@ void PhishingDOMFeatureExtractor::Clear() { ...@@ -381,7 +377,7 @@ void PhishingDOMFeatureExtractor::Clear() {
cur_document_.reset(); cur_document_.reset();
} }
bool PhishingDOMFeatureExtractor::ResetFrameData() { void PhishingDOMFeatureExtractor::ResetFrameData() {
DCHECK(!cur_document_.isNull()); DCHECK(!cur_document_.isNull());
DCHECK(!cur_frame_data_.get()); DCHECK(!cur_frame_data_.get());
...@@ -390,7 +386,6 @@ bool PhishingDOMFeatureExtractor::ResetFrameData() { ...@@ -390,7 +386,6 @@ bool PhishingDOMFeatureExtractor::ResetFrameData() {
cur_frame_data_->domain = cur_frame_data_->domain =
net::RegistryControlledDomainService::GetDomainAndRegistry( net::RegistryControlledDomainService::GetDomainAndRegistry(
cur_document_.url()); cur_document_.url());
return true;
} }
WebKit::WebDocument PhishingDOMFeatureExtractor::GetNextDocument() { WebKit::WebDocument PhishingDOMFeatureExtractor::GetNextDocument() {
......
...@@ -106,8 +106,8 @@ class PhishingDOMFeatureExtractor { ...@@ -106,8 +106,8 @@ class PhishingDOMFeatureExtractor {
void Clear(); void Clear();
// Called after advancing |cur_document_| to update the state in // Called after advancing |cur_document_| to update the state in
// |cur_frame_data_|. Returns true if the state was updated successfully. // |cur_frame_data_|.
bool ResetFrameData(); void ResetFrameData();
// Returns the next document in frame-traversal order from cur_document_. // Returns the next document in frame-traversal order from cur_document_.
// If there are no more documents, returns a null WebDocument. // If there are no more documents, returns a null WebDocument.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment