Commit 79c04974 authored by Matt Falkenhagen's avatar Matt Falkenhagen Committed by Commit Bot

Clarify comment about SubresourceLoaderParams in the non-S13nServiceWorker case.

This comment seems outdated. S13nSW without NetworkService is
supported. The TODO is a bit vague about what was planned to be done.
I assume it was to merge the S13nSW without NetworkService code with
the non-S13nSW without NetworkService code, but there is not a viable
path for that, and as the code will be removed after S13nSW it's not
worth it.

Change-Id: I85097d207af340173508004249e6eebe317a2cfa
Reviewed-on: https://chromium-review.googlesource.com/1149424Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577787}
parent 9d044cd5
...@@ -965,15 +965,12 @@ class NavigationURLLoaderImpl::URLLoaderRequestController ...@@ -965,15 +965,12 @@ class NavigationURLLoaderImpl::URLLoaderRequestController
cloned_navigation_data = navigation_data->Clone(); cloned_navigation_data = navigation_data->Clone();
} }
// non-S13nServiceWorker:
// This is similar to what is done in // This is similar to what is done in
// ServiceWorkerControlleeHandler::MaybeCreateSubresourceLoaderParams(). // ServiceWorkerControlleeHandler::MaybeCreateSubresourceLoaderParams()
// It takes the matching ControllerServiceWorkerInfo (if any) associated // (which is used when S13nServiceWorker is on). It takes the matching
// with the request. It will be sent to the renderer process and used to // ControllerServiceWorkerInfo (if any) associated with the request. It
// intercept requests. // will be sent to the renderer process and used to intercept requests.
// TODO(arthursonzogni): This is needed only for the
// non-S13nServiceWorker case. The S13nServiceWorker case is still not
// supported without the NetworkService. This block needs to be updated
// once support for it will be added.
ServiceWorkerProviderHost* sw_provider_host = ServiceWorkerProviderHost* sw_provider_host =
ServiceWorkerRequestHandler::GetProviderHost(url_request); ServiceWorkerRequestHandler::GetProviderHost(url_request);
if (sw_provider_host && sw_provider_host->controller()) { if (sw_provider_host && sw_provider_host->controller()) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment