Commit 79c402e0 authored by Jimmy Gong's avatar Jimmy Gong Committed by Commit Bot

Add settings search tags for android preferences

- Search tag now includes both "Android settings" and
  "Android preferences" to link to the android settings
  subpage.
- Set "Android preferences" as the primary search tag as it
  matches the text of the link to android preferences app.

Bug: 1115330
Change-Id: Id0dd5b40c2fab9e4a9a41f1d67357475a0a78817
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353675Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797788}
parent 8bbdf184
......@@ -713,10 +713,16 @@
<message name="IDS_OS_SETTINGS_TAG_PLAY_STORE" desc="Text for search result item which, when clicked, navigates the user to Play Store (Android app store) settings.">
Play Store
</message>
<message name="IDS_OS_SETTINGS_TAG_ANDROID_SETTINGS_WITH_PLAY_STORE" desc="Text for search result item which, when clicked, navigates the user to Android app settings, with a button to open Android settings.">
<message name="IDS_OS_SETTINGS_TAG_ANDROID_SETTINGS_WITH_PLAY_STORE" desc="Text for search result item which, when clicked, navigates the user Android app settings, with a button to open Android settings. Alternate phrase for: 'Android settings'">
Android preferences
</message>
<message name="IDS_OS_SETTINGS_TAG_ANDROID_SETTINGS_WITH_PLAY_STORE_ALT1" desc="Text for search result item which, when clicked, navigates the user to Android app settings, with a button to open Android settings. Alternate phrase for: 'Android preferences'">
Android settings
</message>
<message name="IDS_OS_SETTINGS_TAG_ANDROID_SETTINGS" desc="Text for search result item which, when clicked, navigates the user to apps settings, with a button to open Android settings.">
<message name="IDS_OS_SETTINGS_TAG_ANDROID_SETTINGS" desc="Text for search result item which, when clicked, navigates the user to apps settings, with a button to open Android settings. Alternate phrase for: 'Android settings'">
Android preferences
</message>
<message name="IDS_OS_SETTINGS_TAG_ANDROID_SETTINGS_ALT1" desc="Text for search result item which, when clicked, navigates the user to apps settings, with a button to open Android settings. Alternate phrase for: 'Android preferences'">
Android settings
</message>
<message name="IDS_OS_SETTINGS_TAG_ANDROID_TURN_ON_PLAY_STORE" desc="Text for search result item which, when clicked, navigates the user to apps settings, with a button to turn on the Play Store (Android app store). Alternate phrase for: 'Enable Play Store'">
......
12cfebedc9e86a9a3f125a6892d80af80ee9ccbb
\ No newline at end of file
554b178cfa422ddaff5c823cd128bd28f9fb2e36
\ No newline at end of file
......@@ -76,7 +76,9 @@ const std::vector<SearchConcept>& GetAndroidSettingsSearchConcepts() {
mojom::SearchResultIcon::kGooglePlay,
mojom::SearchResultDefaultRank::kMedium,
mojom::SearchResultType::kSetting,
{.setting = mojom::Setting::kManageAndroidPreferences}},
{.setting = mojom::Setting::kManageAndroidPreferences},
{IDS_OS_SETTINGS_TAG_ANDROID_SETTINGS_WITH_PLAY_STORE_ALT1,
SearchConcept::kAltTagEnd}},
});
return *tags;
}
......@@ -88,7 +90,8 @@ const std::vector<SearchConcept>& GetAndroidNoPlayStoreSearchConcepts() {
mojom::SearchResultIcon::kAndroid,
mojom::SearchResultDefaultRank::kMedium,
mojom::SearchResultType::kSetting,
{.setting = mojom::Setting::kManageAndroidPreferences}},
{.setting = mojom::Setting::kManageAndroidPreferences},
{IDS_OS_SETTINGS_TAG_ANDROID_SETTINGS_ALT1, SearchConcept::kAltTagEnd}},
});
return *tags;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment