Commit 79cfca72 authored by caseq@chromium.org's avatar caseq@chromium.org

DevTools: handle Tracing.start in both browser and renderer

Do not return response from browser override for Tracing.start, so
we invoke one in the renderer.
For blink counterpart, see: https://codereview.chromium.org/254613002

BUG=361045

Review URL: https://codereview.chromium.org/256473004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267126 0039d316-1c4b-4281-b951-d872f2087c98
parent dafd4e72
...@@ -169,17 +169,9 @@ DevToolsTracingHandler::OnStart( ...@@ -169,17 +169,9 @@ DevToolsTracingHandler::OnStart(
} }
TracingController::GetInstance()->EnableRecording( TracingController::GetInstance()->EnableRecording(
categories, options, categories, options, TracingController::EnableRecordingDoneCallback());
base::Bind(&DevToolsTracingHandler::OnTracingStarted,
weak_factory_.GetWeakPtr(),
command));
return command->AsyncResponsePromise(); return NULL;
}
void DevToolsTracingHandler::OnTracingStarted(
scoped_refptr<DevToolsProtocol::Command> command) {
SendAsyncResponse(command->SuccessResponse(NULL));
} }
void DevToolsTracingHandler::OnBufferUsage(float usage) { void DevToolsTracingHandler::OnBufferUsage(float usage) {
......
...@@ -27,7 +27,6 @@ class DevToolsTracingHandler : public DevToolsProtocol::Handler { ...@@ -27,7 +27,6 @@ class DevToolsTracingHandler : public DevToolsProtocol::Handler {
void BeginReadingRecordingResult(const base::FilePath& path); void BeginReadingRecordingResult(const base::FilePath& path);
void ReadRecordingResult(const scoped_refptr<base::RefCountedString>& result); void ReadRecordingResult(const scoped_refptr<base::RefCountedString>& result);
void OnTraceDataCollected(const std::string& trace_fragment); void OnTraceDataCollected(const std::string& trace_fragment);
void OnTracingStarted(scoped_refptr<DevToolsProtocol::Command> command);
void OnBufferUsage(float usage); void OnBufferUsage(float usage);
scoped_refptr<DevToolsProtocol::Response> OnStart( scoped_refptr<DevToolsProtocol::Response> OnStart(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment