Commit 79dc3f23 authored by Corentin Wallez's avatar Corentin Wallez Committed by Commit Bot

Revert "Add DCHECKs to match deserialization errors"

This reverts commit 9dce00d2.

Reason for revert: Causes crashes in the webgl_conformance_tests on Android.

Original change's description:
> Add DCHECKs to match deserialization errors
> 
> Two checks about the DrawQuad rects were added as deserialization
> errors. Add equivalent DCHECKs during serialization so the errors are
> caught closer to the source in debug builds.
> 
> Bug: 1066139
> Change-Id: I69665dd200d7ee2028fac6e55bd0264967ed9216
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134609
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Commit-Queue: kylechar <kylechar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#756252}

TBR=rsesek@chromium.org,kylechar@chromium.org

Change-Id: I6a045401c94aedcaa200e4bb9bbb6ae52f72ad73
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1066139
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134238Reviewed-by: default avatarCorentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756287}
parent be623810
...@@ -544,13 +544,11 @@ struct DrawQuadWithSharedQuadState { ...@@ -544,13 +544,11 @@ struct DrawQuadWithSharedQuadState {
template <> template <>
struct StructTraits<viz::mojom::DrawQuadDataView, DrawQuadWithSharedQuadState> { struct StructTraits<viz::mojom::DrawQuadDataView, DrawQuadWithSharedQuadState> {
static const gfx::Rect& rect(const DrawQuadWithSharedQuadState& input) { static const gfx::Rect& rect(const DrawQuadWithSharedQuadState& input) {
DCHECK(input.quad->rect.size().GetCheckedArea().IsValid());
return input.quad->rect; return input.quad->rect;
} }
static const gfx::Rect& visible_rect( static const gfx::Rect& visible_rect(
const DrawQuadWithSharedQuadState& input) { const DrawQuadWithSharedQuadState& input) {
DCHECK(input.quad->rect.Contains(input.quad->visible_rect));
return input.quad->visible_rect; return input.quad->visible_rect;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment