[EXTENSIONS] Fixed bug where height and width were swapped in...

[EXTENSIONS] Fixed bug where height and width were swapped in image_utils::IsIconSufficientlyVisible.

Bug: 805600
Change-Id: I8a56269864d6785d5eb895dc92b55271e5ca3e83
Reviewed-on: https://chromium-review.googlesource.com/1157210Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579826}

extensions/common/image_util.cc

@@ -173,8 +173,8 @@ bool IsIconSufficientlyVisible(const SkBitmap& bitmap) {
   constexpr double kMinPercentVisiblePixels = 0.05;
   const unsigned int total_pixels = bitmap.height() * bitmap.width();
   unsigned int visible_pixels = 0;
-  for (int y = 0; y < bitmap.width(); ++y) {
-    for (int x = 0; x < bitmap.height(); ++x) {
+  for (int y = 0; y < bitmap.height(); ++y) {
+    for (int x = 0; x < bitmap.width(); ++x) {
       if (SkColorGetA(bitmap.getColor(x, y)) >= kAlphaThreshold) {
         ++visible_pixels;
       }

extensions/common/image_util_unittest.cc

@@ -228,6 +228,13 @@ TEST(ImageUtilTest, IsIconSufficientlyVisible) {
     ASSERT_TRUE(LoadPngFromFile(icon_path, &visible_icon));
     EXPECT_TRUE(image_util::IsIconSufficientlyVisible(visible_icon));
   }
+  {
+    // Test with an icon that is rectangular.
+    icon_path = test_dir.AppendASCII("rectangle.png");
+    SkBitmap visible_icon;
+    ASSERT_TRUE(LoadPngFromFile(icon_path, &visible_icon));
+    EXPECT_TRUE(image_util::IsIconSufficientlyVisible(visible_icon));
+  }
 }
 
 }  // namespace extensions