[XProto] Convert keycodes and keysyms using XKB when available
This CL removes usage of XLookupString() that was temporarily introduced by [1]. The issue is that the XKB keyboard map wasn't being used when XKB was available -- the core keyboard map was always being used. This meant that XKB-specific features like keyboard groups and fifth-level shift became unsupported. This CL separates the XKB and non-XKB codepaths into 2 classes: XkbKeyboardState and CoreKeyboardState. This CL also moves the keyboard-related code out of connection.cc into keyboard_state.cc. [1] https://source.chromium.org/chromium/chromium/src/+/a2fd175c6a692351827aacd8e1285d2190ccd4e4 R=sky BUG=1066670 Change-Id: I26023f87c396f5728ce32c0d1fb0275e0335db15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464786 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#821414}
Showing
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.
ui/gfx/x/keyboard_state.cc
0 → 100644
ui/gfx/x/keyboard_state.h
0 → 100644
This diff is collapsed.
Please register or sign in to comment