Commit 7a07bc98 authored by Victor Costan's avatar Victor Costan Committed by Commit Bot

Disable flaky tests in ChromeBrowsingDataRemoverDelegateTest.

ChromeBrowsingDataRemoverDelegateTest.RemoveSafeBrowsingCookie* are
flaking due to errors in the cookie store. It seems like the cookie
store is initialized incorrectly. Disabling until we can investigate
whether the problem is in the test setup or in the cookie store
initialization sequence.

TBR=msramek@chromium.org

Bug: 812589
Change-Id: I174790c0ed3518b88eca3e45304015113d5a5ba8
Reviewed-on: https://chromium-review.googlesource.com/924761Reviewed-by: default avatarVictor Costan <pwnall@chromium.org>
Reviewed-by: default avatarDave Schuyler <dschuyler@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537498}
parent ffd709bf
...@@ -1254,7 +1254,10 @@ class ChromeBrowsingDataRemoverDelegateTest : public testing::Test { ...@@ -1254,7 +1254,10 @@ class ChromeBrowsingDataRemoverDelegateTest : public testing::Test {
DISALLOW_COPY_AND_ASSIGN(ChromeBrowsingDataRemoverDelegateTest); DISALLOW_COPY_AND_ASSIGN(ChromeBrowsingDataRemoverDelegateTest);
}; };
TEST_F(ChromeBrowsingDataRemoverDelegateTest, RemoveSafeBrowsingCookieForever) { // TODO(crbug.com/812589): Disabled due to flakiness in cookie store
// initialization.
TEST_F(ChromeBrowsingDataRemoverDelegateTest,
DISABLED_RemoveSafeBrowsingCookieForever) {
RemoveSafeBrowsingCookieTester tester; RemoveSafeBrowsingCookieTester tester;
tester.AddCookie(); tester.AddCookie();
...@@ -1270,8 +1273,10 @@ TEST_F(ChromeBrowsingDataRemoverDelegateTest, RemoveSafeBrowsingCookieForever) { ...@@ -1270,8 +1273,10 @@ TEST_F(ChromeBrowsingDataRemoverDelegateTest, RemoveSafeBrowsingCookieForever) {
EXPECT_FALSE(tester.ContainsCookie()); EXPECT_FALSE(tester.ContainsCookie());
} }
// TODO(crbug.com/812589): Disabled due to flakiness in cookie store
// initialization.
TEST_F(ChromeBrowsingDataRemoverDelegateTest, TEST_F(ChromeBrowsingDataRemoverDelegateTest,
RemoveSafeBrowsingCookieLastHour) { DISABLED_RemoveSafeBrowsingCookieLastHour) {
RemoveSafeBrowsingCookieTester tester; RemoveSafeBrowsingCookieTester tester;
tester.AddCookie(); tester.AddCookie();
...@@ -1289,8 +1294,10 @@ TEST_F(ChromeBrowsingDataRemoverDelegateTest, ...@@ -1289,8 +1294,10 @@ TEST_F(ChromeBrowsingDataRemoverDelegateTest,
EXPECT_TRUE(tester.ContainsCookie()); EXPECT_TRUE(tester.ContainsCookie());
} }
// TODO(crbug.com/812589): Disabled due to flakiness in cookie store
// initialization.
TEST_F(ChromeBrowsingDataRemoverDelegateTest, TEST_F(ChromeBrowsingDataRemoverDelegateTest,
RemoveSafeBrowsingCookieForeverWithPredicate) { DISABLED_RemoveSafeBrowsingCookieForeverWithPredicate) {
RemoveSafeBrowsingCookieTester tester; RemoveSafeBrowsingCookieTester tester;
tester.AddCookie(); tester.AddCookie();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment