Commit 7a0da48f authored by Yuki Shiino's avatar Yuki Shiino Committed by Commit Bot

bind-gen: Initialize ScriptValue with IDL null (= v8::Null)

Bug: 839389
Change-Id: I20ca170b3536309e887f97a50710e075cd1caaed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142669
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: default avatarHitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758438}
parent 32408e19
...@@ -340,8 +340,8 @@ def make_default_value_expr(idl_type, default_value): ...@@ -340,8 +340,8 @@ def make_default_value_expr(idl_type, default_value):
is_initializer_lightweight = True is_initializer_lightweight = True
assignment_value = "nullptr" assignment_value = "nullptr"
elif type_info.value_t == "ScriptValue": elif type_info.value_t == "ScriptValue":
initializer = None # ScriptValue::IsEmpty() by default initializer = "${isolate}, v8::Null(${isolate})"
assignment_value = "ScriptValue()" assignment_value = "ScriptValue::CreateNull(${isolate})"
elif idl_type.unwrap().is_union: elif idl_type.unwrap().is_union:
initializer = None # <union_type>::IsNull() by default initializer = None # <union_type>::IsNull() by default
assignment_value = "{}()".format(type_info.value_t) assignment_value = "{}()".format(type_info.value_t)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment