Commit 7a15a747 authored by Kamila Hasanbega's avatar Kamila Hasanbega Committed by Commit Bot

Revert "Reenable PromptForXHRWithoutOnSubmit and...

Revert "Reenable PromptForXHRWithoutOnSubmit and PromptForFetchWithNewPasswordsWithoutOnSubmit tests"

This reverts commit 557416cf.

Reason for revert: The tests started to fail here https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/30656?blamelist=1#blamelist-tab

Original change's description:
> Reenable PromptForXHRWithoutOnSubmit and PromptForFetchWithNewPasswordsWithoutOnSubmit tests
> 
> The two probable reasons for the flakiness were:
> - we didn't wait until the keystrokes were processed in the renderer. See
> crbug.com/955455
> - we don't wait for the password store returning some results after navigation.
> 
> Both are fixed in the CL. Let's observe the pass rate.
> 
> Bug: 1013743
> Change-Id: Ic328afbe2cd652119a773c28d49ff450cf0d5405
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879237
> Reviewed-by: Dominic Battré <battre@chromium.org>
> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#709464}

TBR=battre@chromium.org,vasilii@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1013743
Change-Id: Iee2265f768e89fb112157645c1fadd715c35fb53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890051Reviewed-by: default avatarKamila Hasanbega <hkamila@chromium.org>
Commit-Queue: Kamila Hasanbega <hkamila@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710736}
parent 735ff34c
......@@ -179,18 +179,19 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerInteractiveTest,
prompt_observer.WaitForManagementState();
}
// Flaky. https://crbug.com/1013743
IN_PROC_BROWSER_TEST_F(PasswordManagerInteractiveTest,
PromptForXHRWithoutOnSubmit) {
DISABLED_PromptForXHRWithoutOnSubmit) {
NavigateToFile("/password/password_xhr_submit.html");
// Verify that if XHR navigation occurs and the form is properly filled out,
// we try and save the password even though onsubmit hasn't been called.
FillElementWithValue("username_field", "user");
FillElementWithValue("password_field", "1234");
// Make sure that the keystrokes were processed.
WaitForElementValue("password_field", "1234");
NavigationObserver observer(WebContents());
ASSERT_TRUE(content::ExecuteScript(WebContents(), "send_xhr()"));
BubbleObserver(WebContents()).WaitForAutomaticSavePrompt();
observer.Wait();
EXPECT_TRUE(BubbleObserver(WebContents()).IsSavePromptShownAutomatically());
}
IN_PROC_BROWSER_TEST_F(PasswordManagerInteractiveTest,
......@@ -226,8 +227,9 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerInteractiveTest,
EXPECT_TRUE(BubbleObserver(WebContents()).IsSavePromptShownAutomatically());
}
// Flaky. https://crbug.com/1013743
IN_PROC_BROWSER_TEST_F(PasswordManagerInteractiveTest,
PromptForFetchWithNewPasswordsWithoutOnSubmit) {
DISABLED_PromptForFetchWithNewPasswordsWithoutOnSubmit) {
NavigateToFile("/password/password_fetch_submit.html");
// Verify that if Fetch navigation occurs and the form is properly filled out,
......@@ -237,10 +239,10 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerInteractiveTest,
FillElementWithValue("signup_username_field", "user");
FillElementWithValue("signup_password_field", "1234");
FillElementWithValue("confirmation_password_field", "1234");
// Make sure that the keystrokes were processed.
WaitForElementValue("confirmation_password_field", "1234");
NavigationObserver observer(WebContents());
ASSERT_TRUE(content::ExecuteScript(WebContents(), "send_fetch()"));
BubbleObserver(WebContents()).WaitForAutomaticSavePrompt();
observer.Wait();
EXPECT_TRUE(BubbleObserver(WebContents()).IsSavePromptShownAutomatically());
}
// Disabled for flakiness crbug.com/849582.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment